From: Andrew Morton <akpm@linux-foundation.org>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: nishimura@mxp.nes.nec.co.jp,
Daisuke Nishimura <d-nishimura@mtf.biglobe.ne.jp>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
"balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>
Subject: Re: [PATCH 2/2] memcg : share event counter rather than duplicate v2
Date: Tue, 9 Mar 2010 15:15:14 -0800 [thread overview]
Message-ID: <20100309151514.56b8396d.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100215091906.c08a6ed7.kamezawa.hiroyu@jp.fujitsu.com>
On Mon, 15 Feb 2010 09:19:06 +0900
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> > > /**
> > > @@ -1760,6 +1768,11 @@ static int mem_cgroup_move_account(struc
> > > ret = 0;
> > > }
> > > unlock_page_cgroup(pc);
> > > + /*
> > > + * check events
> > > + */
> > > + memcg_check_events(to, pc->page);
> > > + memcg_check_events(from, pc->page);
> > > return ret;
> > > }
> > >
> > Strictly speaking, "if (!ret)" would be needed(it's not a big deal, though).
> >
> Hmm. ok. I'll check.
I'll assume that your checking resulted in happiness with the existing
patch ;)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-03-09 23:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-12 6:44 [PATCH 0/2] memcg patches around event counting...softlimit and thresholds KAMEZAWA Hiroyuki
2010-02-12 6:47 ` [PATCH 1/2] memcg : update softlimit and threshold at commit KAMEZAWA Hiroyuki
2010-02-12 7:33 ` Daisuke Nishimura
2010-02-12 7:42 ` KAMEZAWA Hiroyuki
2010-02-12 6:48 ` [PATCH 2/2] memcg: share event counter rather than duplicate KAMEZAWA Hiroyuki
2010-02-12 7:40 ` Daisuke Nishimura
2010-02-12 7:41 ` KAMEZAWA Hiroyuki
2010-02-12 7:46 ` Kirill A. Shutemov
2010-02-12 7:46 ` KAMEZAWA Hiroyuki
2010-02-12 8:07 ` Kirill A. Shutemov
2010-02-12 8:19 ` KAMEZAWA Hiroyuki
2010-02-12 8:49 ` Kirill A. Shutemov
2010-02-12 8:51 ` KAMEZAWA Hiroyuki
2010-02-12 9:05 ` [PATCH 0/2] memcg patches around event counting...softlimit and thresholds v2 KAMEZAWA Hiroyuki
2010-02-12 9:06 ` [PATCH 1/2] memcg: update threshold and softlimit at commit v2 KAMEZAWA Hiroyuki
2010-02-12 9:09 ` [PATCH 2/2] memcg : share event counter rather than duplicate v2 KAMEZAWA Hiroyuki
2010-02-12 11:48 ` Daisuke Nishimura
2010-02-15 0:19 ` KAMEZAWA Hiroyuki
2010-03-09 23:15 ` Andrew Morton [this message]
2010-02-15 10:57 ` Kirill A. Shutemov
2010-02-16 0:16 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100309151514.56b8396d.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=d-nishimura@mtf.biglobe.ne.jp \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kirill@shutemov.name \
--cc=linux-mm@kvack.org \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).