From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with ESMTP id 5AEB262001F for ; Wed, 17 Mar 2010 15:03:40 -0400 (EDT) Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58]) by e28smtp01.in.ibm.com (8.14.3/8.13.1) with ESMTP id o2HJ2jo2023447 for ; Thu, 18 Mar 2010 00:32:45 +0530 Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o2HJ2j0B3375244 for ; Thu, 18 Mar 2010 00:32:45 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o2HJ2i0e011985 for ; Thu, 18 Mar 2010 06:02:45 +1100 Date: Thu, 18 Mar 2010 00:32:41 +0530 From: Balbir Singh Subject: Re: [PATCH -mmotm 2/5] memcg: dirty memory documentation Message-ID: <20100317190241.GW18054@balbir.in.ibm.com> Reply-To: balbir@linux.vnet.ibm.com References: <1268609202-15581-1-git-send-email-arighi@develer.com> <1268609202-15581-3-git-send-email-arighi@develer.com> <20100316164121.024e35d8.nishimura@mxp.nes.nec.co.jp> <49b004811003171048h5f27405oe6ea39a103bc4ee3@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <49b004811003171048h5f27405oe6ea39a103bc4ee3@mail.gmail.com> Sender: owner-linux-mm@kvack.org To: Greg Thelen Cc: Daisuke Nishimura , Andrea Righi , KAMEZAWA Hiroyuki , Vivek Goyal , Peter Zijlstra , Trond Myklebust , Suleiman Souhlal , "Kirill A. Shutemov" , Andrew Morton , containers@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: * Greg Thelen [2010-03-17 09:48:18]: > On Mon, Mar 15, 2010 at 11:41 PM, Daisuke Nishimura > wrote: > > On Mon, 15 Mar 2010 00:26:39 +0100, Andrea Righi wrote: > >> Document cgroup dirty memory interfaces and statistics. > >> > >> Signed-off-by: Andrea Righi > >> --- > >> Documentation/cgroups/memory.txt | 36 ++++++++++++++++++++++++++++++++++++ > >> 1 files changed, 36 insertions(+), 0 deletions(-) > >> > >> diff --git a/Documentation/cgroups/memory.txt b/Documentation/cgroups/memory.txt > >> index 49f86f3..38ca499 100644 > >> --- a/Documentation/cgroups/memory.txt > >> +++ b/Documentation/cgroups/memory.txt > >> @@ -310,6 +310,11 @@ cache - # of bytes of page cache memory. > >> rss - # of bytes of anonymous and swap cache memory. > >> pgpgin - # of pages paged in (equivalent to # of charging events). > >> pgpgout - # of pages paged out (equivalent to # of uncharging events). > >> +filedirty - # of pages that are waiting to get written back to the disk. > >> +writeback - # of pages that are actively being written back to the disk. > >> +writeback_tmp - # of pages used by FUSE for temporary writeback buffers. > >> +nfs - # of NFS pages sent to the server, but not yet committed to > >> + the actual storage. > > Should these new memory.stat counters (filedirty, etc) report byte > counts rather than page counts? I am thinking that byte counters > would make reporting more obvious depending on how heterogeneous page > sizes are used. Byte counters would also agree with /proc/meminfo. > Within the kernel we could still maintain page counts. The only > change would be to the reporting routine, mem_cgroup_get_local_stat(), > which would scale the page counts by PAGE_SIZE as it does for for > cache,rss,etc. > I agree, byte counts would be better than page counts. pgpin and pgpout are special cases where the pages matter, the size does not due to the nature of the operation. -- Three Cheers, Balbir -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org