From: Shaohua Li <shaohua.li@intel.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"Wu, Fengguang" <fengguang.wu@intel.com>
Subject: Re: [PATCH]vmscan: handle underflow for get_scan_ratio
Date: Tue, 30 Mar 2010 16:13:40 +0800 [thread overview]
Message-ID: <20100330081340.GA23691@sli10-desk.sh.intel.com> (raw)
In-Reply-To: <20100330160820.8EA8.A69D9226@jp.fujitsu.com>
On Tue, Mar 30, 2010 at 03:31:40PM +0800, KOSAKI Motohiro wrote:
> > > > > Very unfortunately, this patch isn't acceptable. In past time, vmscan
> > > > > had similar logic, but 1% swap-out made lots bug reports.
> > > > can you elaborate this?
> > > > Completely restore previous behavior (do full scan with priority 0) is
> > > > ok too.
> > >
> > > This is a option. but we need to know the root cause anyway.
> > I thought I mentioned the root cause in first mail. My debug shows
> > recent_rotated[0] is big, but recent_rotated[1] is almost zero, which makes
> > percent[0] 0. But you can double check too.
>
> To revert can save percent[0]==0 && priority==0 case. but it shouldn't
> happen, I think. It mean to happen big latency issue.
>
> Can you please try following patch? Also, I'll prepare reproduce environment soon.
still oom with the patch.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-03-30 8:13 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 5:53 [PATCH]vmscan: handle underflow for get_scan_ratio Shaohua Li
2010-03-30 6:08 ` KOSAKI Motohiro
2010-03-30 6:32 ` Shaohua Li
2010-03-30 6:40 ` KOSAKI Motohiro
2010-03-30 6:53 ` Shaohua Li
2010-03-30 7:31 ` KOSAKI Motohiro
2010-03-30 8:13 ` Shaohua Li [this message]
2010-03-31 4:53 ` Shaohua Li
2010-03-31 5:38 ` KOSAKI Motohiro
2010-03-31 5:51 ` Wu Fengguang
2010-03-31 6:00 ` KOSAKI Motohiro
2010-03-31 6:03 ` Wu Fengguang
2010-04-01 22:16 ` Andrew Morton
2010-04-02 9:13 ` KOSAKI Motohiro
2010-04-06 1:22 ` Wu Fengguang
2010-04-06 3:36 ` Rik van Riel
2010-03-31 5:53 ` KOSAKI Motohiro
2010-04-02 6:50 ` Shaohua Li
2010-04-02 9:14 ` KOSAKI Motohiro
2010-04-02 9:24 ` Shaohua Li
2010-04-04 14:19 ` KOSAKI Motohiro
2010-04-06 1:25 ` Shaohua Li
2010-04-06 1:36 ` KOSAKI Motohiro
2010-04-06 1:50 ` Wu Fengguang
2010-04-06 2:06 ` KOSAKI Motohiro
2010-04-06 2:30 ` Wu Fengguang
2010-04-06 2:58 ` KOSAKI Motohiro
2010-04-06 3:31 ` Wu Fengguang
2010-04-06 3:40 ` Rik van Riel
2010-04-06 4:49 ` Wu Fengguang
2010-04-06 5:09 ` Shaohua Li
2010-04-04 0:48 ` Wu Fengguang
2010-04-06 1:27 ` Shaohua Li
2010-04-06 5:03 ` Wu Fengguang
2010-04-06 5:36 ` Shaohua Li
2010-04-09 6:51 ` Shaohua Li
2010-04-09 21:20 ` Andrew Morton
2010-04-09 21:25 ` Rik van Riel
2010-04-13 1:30 ` KOSAKI Motohiro
2010-04-13 2:42 ` Rik van Riel
2010-04-13 7:55 ` KOSAKI Motohiro
2010-04-13 8:55 ` KOSAKI Motohiro
2010-04-14 1:27 ` Shaohua Li
2010-04-15 3:25 ` KOSAKI Motohiro
2010-04-12 1:57 ` Shaohua Li
2010-03-31 5:41 ` Wu Fengguang
2010-03-30 10:17 ` Minchan Kim
2010-03-30 10:25 ` KOSAKI Motohiro
2010-03-30 11:56 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100330081340.GA23691@sli10-desk.sh.intel.com \
--to=shaohua.li@intel.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).