From: Evgeniy Polyakov <zbr@ioremap.net>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: "Robert P. J. Day" <rpjday@crashcourse.ca>,
linux-mm@kvack.org, Joern Engel <joern@logfs.org>
Subject: Re: why are some low-level MM routines being exported?
Date: Sun, 4 Apr 2010 20:03:28 +0400 [thread overview]
Message-ID: <20100404160328.GA30540@ioremap.net> (raw)
In-Reply-To: <1270396784.1814.92.camel@barrios-desktop>
On Mon, Apr 05, 2010 at 12:59:44AM +0900, Minchan Kim (minchan.kim@gmail.com) wrote:
> > perusing the code in mm/filemap.c and i'm curious as to why routines
> > like, for example, add_to_page_cache_lru() are being exported. is it
> > really expected that loadable modules might access routines like that
> > directly?
>
> It is added by 18bc0bbd162e3 for pohmelfs and now used by logfs, too.
> I didn't noticed that at that time.
> With git log, any mm guys didn't add Signed-off-by or Reviewed-by.
>
> I think it's not good for file system or module to use it directly.
> It would make LRU management harder.
How come?
> Is it really needed? Let's think again.
Yes, it is really needed. It is not a some king of low-level mm magic to
export, but a useful interface to work with LRU lists instead of
copy-paste it into own machinery.
--
Evgeniy Polyakov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-04-04 16:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-04 15:27 why are some low-level MM routines being exported? Robert P. J. Day
2010-04-04 15:59 ` Minchan Kim
2010-04-04 16:03 ` Evgeniy Polyakov [this message]
2010-04-04 16:17 ` Minchan Kim
2010-04-04 16:21 ` Minchan Kim
2010-04-04 18:15 ` Evgeniy Polyakov
2010-04-05 0:36 ` Minchan Kim
2010-04-05 12:47 ` Evgeniy Polyakov
2010-04-05 14:31 ` Minchan Kim
2010-04-04 19:55 ` Jörn Engel
2010-04-05 0:59 ` Minchan Kim
2010-04-05 5:30 ` Jörn Engel
2010-04-05 6:20 ` Minchan Kim
2010-04-05 6:22 ` Minchan Kim
2010-04-05 7:13 ` Jörn Engel
2010-04-05 8:26 ` Minchan Kim
2010-04-05 11:19 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100404160328.GA30540@ioremap.net \
--to=zbr@ioremap.net \
--cc=joern@logfs.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).