From: Evgeniy Polyakov <zbr@ioremap.net>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: "Robert P. J. Day" <rpjday@crashcourse.ca>,
linux-mm@kvack.org, Joern Engel <joern@logfs.org>
Subject: Re: why are some low-level MM routines being exported?
Date: Sun, 4 Apr 2010 22:15:51 +0400 [thread overview]
Message-ID: <20100404181550.GA2350@ioremap.net> (raw)
In-Reply-To: <1270398112.1814.114.camel@barrios-desktop>
On Mon, Apr 05, 2010 at 01:21:52AM +0900, Minchan Kim (minchan.kim@gmail.com) wrote:
> > > It is added by 18bc0bbd162e3 for pohmelfs and now used by logfs, too.
> > > I didn't noticed that at that time.
> > > With git log, any mm guys didn't add Signed-off-by or Reviewed-by.
> > >
> > > I think it's not good for file system or module to use it directly.
> > > It would make LRU management harder.
> >
> > How come?
>
> What I have a concern is that if file systems or some modules start to
> overuse it to manage pages LRU directly, some mistake of them would make
> system global LRU stupid and make system wrong.
All filesystems already call it through find_or_create_page() or
grab_page() invoked via read path. In some cases fs has more than
one page grabbed via its internal path where data to be read is
already placed, so it may want just to add those pages into mm lru.
--
Evgeniy Polyakov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-04-04 18:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-04 15:27 why are some low-level MM routines being exported? Robert P. J. Day
2010-04-04 15:59 ` Minchan Kim
2010-04-04 16:03 ` Evgeniy Polyakov
2010-04-04 16:17 ` Minchan Kim
2010-04-04 16:21 ` Minchan Kim
2010-04-04 18:15 ` Evgeniy Polyakov [this message]
2010-04-05 0:36 ` Minchan Kim
2010-04-05 12:47 ` Evgeniy Polyakov
2010-04-05 14:31 ` Minchan Kim
2010-04-04 19:55 ` Jörn Engel
2010-04-05 0:59 ` Minchan Kim
2010-04-05 5:30 ` Jörn Engel
2010-04-05 6:20 ` Minchan Kim
2010-04-05 6:22 ` Minchan Kim
2010-04-05 7:13 ` Jörn Engel
2010-04-05 8:26 ` Minchan Kim
2010-04-05 11:19 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100404181550.GA2350@ioremap.net \
--to=zbr@ioremap.net \
--cc=joern@logfs.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).