From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with ESMTP id EE6A86B01E3 for ; Mon, 5 Apr 2010 15:10:27 -0400 (EDT) Date: Mon, 5 Apr 2010 12:09:06 -0700 From: Andrew Morton Subject: Re: [PATCH 00 of 41] Transparent Hugepage Support #17 Message-Id: <20100405120906.0abe8e58.akpm@linux-foundation.org> In-Reply-To: References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Andrea Arcangeli Cc: linux-mm@kvack.org, Marcelo Tosatti , Adam Litke , Avi Kivity , Izik Eidus , Hugh Dickins , Nick Piggin , Rik van Riel , Mel Gorman , Dave Hansen , Benjamin Herrenschmidt , Ingo Molnar , Mike Travis , KAMEZAWA Hiroyuki , Christoph Lameter , Chris Wright , bpicco@redhat.com, KOSAKI Motohiro , Balbir Singh , Arnd Bergmann , "Michael S. Tsirkin" , Peter Zijlstra , Johannes Weiner , Daisuke Nishimura List-ID: Problem. It appears that these patches have only been sent to linux-mm. Linus doesn't read linux-mm and has never seen them. I do think we should get things squared away with him regarding the overall intent and implementation approach before trying to go further. I forwarded "[PATCH 27 of 41] transparent hugepage core" and his summary was "So I don't hate the patch, but it sure as hell doesn't make me happy either. And if the only advantage is about TLB miss costs, I really don't see the point personally.". So if there's more benefit to the patches than this, that will need some expounding upon. So I'd suggest that you a) address some minor Linus comments which I'll forward separately, b) rework [patch 0/n] to provide a complete description of the benefits and the downsides (if that isn't there already) and c) resend everything, cc'ing Linus and linux-kernel and we'll get it thrashed out. Sorry. Normally I use my own judgement on MM patches, but in this case if I was asked "why did you send all this stuff", I don't believe I personally have strong enough arguments to justify the changes - you're in a better position than I to make that case. Plus this is a *large* patchset, and it plays in an area where Linus is known to have, err, opinions. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org