From: Andrew Morton <akpm@linux-foundation.org>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>,
Andreas Mohr <andi@lisas.de>, Jens Axboe <axboe@kernel.dk>,
Minchan Kim <minchan.kim@gmail.com>,
Linux Memory Management List <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rik van Riel <riel@redhat.com>,
Lee Schermerhorn <Lee.Schermerhorn@hp.com>
Subject: Re: [PATCH] vmscan: page_check_references() check low order lumpy reclaim properly
Date: Fri, 16 Apr 2010 14:18:41 -0700 [thread overview]
Message-ID: <20100416141841.300d2361.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100416115437.27AD.A69D9226@jp.fujitsu.com>
On Fri, 16 Apr 2010 12:16:18 +0900 (JST)
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> If vmscan is under lumpy reclaim mode, it have to ignore referenced bit
> for making contenious free pages. but current page_check_references()
> doesn't.
>
> Fixes it.
>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> ---
> mm/vmscan.c | 32 +++++++++++++++++---------------
> 1 files changed, 17 insertions(+), 15 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 3ff3311..13d9546 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -77,6 +77,8 @@ struct scan_control {
>
> int order;
>
> + int lumpy_reclaim;
> +
Needs a comment explaining its role, please. Something like "direct
this reclaim run to perform lumpy reclaim"?
A clearer name might be "lumpy_relcaim_mode"?
Making it a `bool' would clarify things too.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-04-16 21:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100404221349.GA18036@rhlx01.hs-esslingen.de>
[not found] ` <20100405105319.GA16528@rhlx01.hs-esslingen.de>
2010-04-07 7:00 ` 32GB SSD on USB1.1 P3/700 == ___HELL___ (2.6.34-rc3) Wu Fengguang
2010-04-07 7:08 ` Wu Fengguang
2010-04-15 3:31 ` KOSAKI Motohiro
2010-04-15 4:19 ` Wu Fengguang
2010-04-15 4:32 ` KOSAKI Motohiro
2010-04-15 4:41 ` Wu Fengguang
2010-04-15 4:55 ` KOSAKI Motohiro
2010-04-15 5:19 ` Wu Fengguang
2010-04-16 3:16 ` [PATCH] vmscan: page_check_references() check low order lumpy reclaim properly KOSAKI Motohiro
2010-04-16 4:26 ` Minchan Kim
2010-04-16 5:33 ` KOSAKI Motohiro
2010-04-16 21:18 ` Andrew Morton [this message]
2010-05-13 2:54 ` KOSAKI Motohiro
2010-04-07 8:39 ` 32GB SSD on USB1.1 P3/700 == ___HELL___ (2.6.34-rc3) Minchan Kim
2010-04-07 8:52 ` Wu Fengguang
2010-04-07 11:17 ` Andreas Mohr
2010-04-08 19:46 ` Andreas Mohr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100416141841.300d2361.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Lee.Schermerhorn@hp.com \
--cc=andi@lisas.de \
--cc=axboe@kernel.dk \
--cc=fengguang.wu@intel.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).