From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with ESMTP id 9932F6B01F0 for ; Fri, 16 Apr 2010 17:18:54 -0400 (EDT) Date: Fri, 16 Apr 2010 14:18:41 -0700 From: Andrew Morton Subject: Re: [PATCH] vmscan: page_check_references() check low order lumpy reclaim properly Message-Id: <20100416141841.300d2361.akpm@linux-foundation.org> In-Reply-To: <20100416115437.27AD.A69D9226@jp.fujitsu.com> References: <20100415135031.D186.A69D9226@jp.fujitsu.com> <20100415051911.GA17110@localhost> <20100416115437.27AD.A69D9226@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: KOSAKI Motohiro Cc: Wu Fengguang , Andreas Mohr , Jens Axboe , Minchan Kim , Linux Memory Management List , "linux-kernel@vger.kernel.org" , Rik van Riel , Lee Schermerhorn List-ID: On Fri, 16 Apr 2010 12:16:18 +0900 (JST) KOSAKI Motohiro wrote: > If vmscan is under lumpy reclaim mode, it have to ignore referenced bit > for making contenious free pages. but current page_check_references() > doesn't. > > Fixes it. > > Signed-off-by: KOSAKI Motohiro > --- > mm/vmscan.c | 32 +++++++++++++++++--------------- > 1 files changed, 17 insertions(+), 15 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 3ff3311..13d9546 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -77,6 +77,8 @@ struct scan_control { > > int order; > > + int lumpy_reclaim; > + Needs a comment explaining its role, please. Something like "direct this reclaim run to perform lumpy reclaim"? A clearer name might be "lumpy_relcaim_mode"? Making it a `bool' would clarify things too. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org