From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with ESMTP id ABFE26B01EF for ; Tue, 20 Apr 2010 18:52:33 -0400 (EDT) Date: Tue, 20 Apr 2010 15:51:22 -0700 From: Andrew Morton Subject: Re: Suspicious compilation warning Message-Id: <20100420155122.6f2c26eb.akpm@linux-foundation.org> In-Reply-To: References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Marcelo Jimenez Cc: linux-arm-kernel@lists.infradead.org, KOSAKI Motohiro , Christoph Lameter , Mel Gorman , Minchan Kim , "H. Peter Anvin" , Yinghai Lu , Stephen Rothwell , linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: On Mon, 19 Apr 2010 20:27:43 -0300 Marcelo Jimenez wrote: > I get this warning while compiling for ARM/SA1100: > > mm/sparse.c: In function '__section_nr': > mm/sparse.c:135: warning: 'root' is used uninitialized in this function > > With a small patch in fs/proc/meminfo.c, I find that NR_SECTION_ROOTS > is zero, which certainly explains the warning. > > # cat /proc/meminfo > NR_SECTION_ROOTS=0 > NR_MEM_SECTIONS=32 > SECTIONS_PER_ROOT=512 > SECTIONS_SHIFT=5 > MAX_PHYSMEM_BITS=32 hm, who owns sparsemem nowadays? Nobody identifiable. Does it make physical sense to have SECTIONS_PER_ROOT > NR_MEM_SECTIONS? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org