linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* Cleancache [PATCH 6/7] (was Transcendent Memory): ext4 hook
@ 2010-04-22 12:15 Dan Magenheimer
  0 siblings, 0 replies; 3+ messages in thread
From: Dan Magenheimer @ 2010-04-22 12:15 UTC (permalink / raw)
  To: adilger, akpm, chris.mason, dave.mccracken, JBeulich, jeremy,
	joel.becker, kurt.hackel, linux-btrfs, linux-ext4, linux-fsdevel,
	linux-kernel, linux-mm, matthew, mfasheh, ngupta, npiggin,
	ocfs2-devel, riel, tytso, viro

Cleancache [PATCH 6/7] (was Transcendent Memory): ext4 hook

Filesystems must explicitly enable cleancache.  For ext4,
all other cleancache hooks are in the VFS layer.

Signed-off-by: Dan Magenheimer <dan.magenheimer@oracle.com>

Diffstat:
 super.c                                  |    2 ++
 1 file changed, 2 insertions(+)

--- linux-2.6.34-rc5/fs/ext4/super.c	2010-04-19 17:29:56.000000000 -0600
+++ linux-2.6.34-rc5-cleancache/fs/ext4/super.c	2010-04-21 10:13:00.000000000 -0600
@@ -39,6 +39,7 @@
 #include <linux/ctype.h>
 #include <linux/log2.h>
 #include <linux/crc16.h>
+#include <linux/cleancache.h>
 #include <asm/uaccess.h>
 
 #include "ext4.h"
@@ -1784,6 +1785,7 @@ static int ext4_setup_super(struct super
 			EXT4_INODES_PER_GROUP(sb),
 			sbi->s_mount_opt);
 
+	sb->cleancache_poolid = cleancache_init_fs(PAGE_SIZE);
 	return res;
 }
 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Cleancache [PATCH 6/7] (was Transcendent Memory): ext4 hook
@ 2010-04-22 13:29 Dan Magenheimer
  2010-04-28 23:08 ` Andreas Dilger
  0 siblings, 1 reply; 3+ messages in thread
From: Dan Magenheimer @ 2010-04-22 13:29 UTC (permalink / raw)
  To: chris.mason, viro, akpm, adilger, tytso, mfasheh, joel.becker,
	matthew, linux-btrfs, linux-kernel, linux-fsdevel, linux-ext4,
	ocfs2-devel, linux-mm, ngupta, jeremy, JBeulich, kurt.hackel,
	npiggin, dave.mccracken, riel

Cleancache [PATCH 6/7] (was Transcendent Memory): ext4 hook

Filesystems must explicitly enable cleancache.  For ext4,
all other cleancache hooks are in the VFS layer.

Signed-off-by: Dan Magenheimer <dan.magenheimer@oracle.com>

Diffstat:
 super.c                                  |    2 ++
 1 file changed, 2 insertions(+)

--- linux-2.6.34-rc5/fs/ext4/super.c	2010-04-19 17:29:56.000000000 -0600
+++ linux-2.6.34-rc5-cleancache/fs/ext4/super.c	2010-04-21 10:13:00.000000000 -0600
@@ -39,6 +39,7 @@
 #include <linux/ctype.h>
 #include <linux/log2.h>
 #include <linux/crc16.h>
+#include <linux/cleancache.h>
 #include <asm/uaccess.h>
 
 #include "ext4.h"
@@ -1784,6 +1785,7 @@ static int ext4_setup_super(struct super
 			EXT4_INODES_PER_GROUP(sb),
 			sbi->s_mount_opt);
 
+	sb->cleancache_poolid = cleancache_init_fs(PAGE_SIZE);
 	return res;
 }
 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Cleancache [PATCH 6/7] (was Transcendent Memory): ext4 hook
  2010-04-22 13:29 Cleancache [PATCH 6/7] (was Transcendent Memory): ext4 hook Dan Magenheimer
@ 2010-04-28 23:08 ` Andreas Dilger
  0 siblings, 0 replies; 3+ messages in thread
From: Andreas Dilger @ 2010-04-28 23:08 UTC (permalink / raw)
  To: Dan Magenheimer
  Cc: Chris Mason, Al Viro, Andrew Morton, Theodore Ts'o, mfasheh,
	Joel Becker, Matthew Wilcox, linux-btrfs,
	linux-kernel@vger.kernel.org Mailinglist, linux-fsdevel,
	linux-ext4 development, ocfs2-devel, linux-mm, ngupta,
	Jeremy Fitzhardinge, JBeulich, kurt.hackel, Nick Piggin,
	dave.mccracken, Rik van Riel

On 2010-04-22, at 07:29, Dan Magenheimer wrote:
> Cleancache [PATCH 6/7] (was Transcendent Memory): ext4 hook
> 
> Filesystems must explicitly enable cleancache.  For ext4,
> all other cleancache hooks are in the VFS layer.
> 
> Signed-off-by: Dan Magenheimer <dan.magenheimer@oracle.com>

Given the minimal changes being done to ext3/ext4, I don't have any objection to this.  Being able to hook ext4 into SSDs for hierarchical caching is something that will become increasingly important for huge ext4 filesystems.

Acked-by: Andreas Dilger <adilger@sun.com>

> Diffstat:
> super.c                                  |    2 ++
> 1 file changed, 2 insertions(+)
> 
> --- linux-2.6.34-rc5/fs/ext4/super.c	2010-04-19 17:29:56.000000000 -0600
> +++ linux-2.6.34-rc5-cleancache/fs/ext4/super.c	2010-04-21 10:13:00.000000000 -0600
> @@ -39,6 +39,7 @@
>  #include <linux/ctype.h>
>  #include <linux/log2.h>
>  #include <linux/crc16.h>
> +#include <linux/cleancache.h>
>  #include <asm/uaccess.h>
>  
>  #include "ext4.h"
> @@ -1784,6 +1785,7 @@ static int ext4_setup_super(struct super
>  			EXT4_INODES_PER_GROUP(sb),
>  			sbi->s_mount_opt);
> 
> +	sb->cleancache_poolid = cleancache_init_fs(PAGE_SIZE);
>  	return res;
>  }


Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-04-28 23:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-22 13:29 Cleancache [PATCH 6/7] (was Transcendent Memory): ext4 hook Dan Magenheimer
2010-04-28 23:08 ` Andreas Dilger
  -- strict thread matches above, loose matches on Subject: below --
2010-04-22 12:15 Dan Magenheimer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).