From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with SMTP id 2E43C600375 for ; Sat, 24 Apr 2010 10:31:24 -0400 (EDT) Date: Sat, 24 Apr 2010 16:30:44 +0200 From: Andrea Arcangeli Subject: Re: [PATCH 04/14] mm,migration: Allow the migration of PageSwapCache pages Message-ID: <20100424143044.GD32034@random.random> References: <1271946226.2100.211.camel@barrios-desktop> <1271947206.2100.216.camel@barrios-desktop> <20100422154443.GD30306@csn.ul.ie> <20100423183135.GT32034@random.random> <20100423192311.GC14351@csn.ul.ie> <20100423193948.GU32034@random.random> <20100423213549.GV32034@random.random> <20100424105226.GF14351@csn.ul.ie> <20100424111340.GB32034@random.random> <20100424115936.GG14351@csn.ul.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100424115936.GG14351@csn.ul.ie> Sender: owner-linux-mm@kvack.org To: Mel Gorman Cc: Minchan Kim , KAMEZAWA Hiroyuki , Christoph Lameter , Andrew Morton , Adam Litke , Avi Kivity , David Rientjes , KOSAKI Motohiro , Rik van Riel , linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: On Sat, Apr 24, 2010 at 12:59:37PM +0100, Mel Gorman wrote: > Well, to me this is also good because it shows it's not an existing bug in > migration or a new bug introduced by compaction either. Previously I hadn't > seen this bug either but until relatively recently, the bulk of the testing > was against 2.6.33. I suggest to test again with aa.git as soon as I make a new release with your v8 code (probably today). I didn't merge the swapcache locked debug patch that tries to recover the thing after the fact. No problem here with swapcache apparently and your v8 and latest numa-aware khugepaged code is under stress for the last 12 hours. Other than full numa awareness in all hugepage allocations and your v8 code, I added a generic document that needs review and I plan to add a config tweak to select the default to be madvise or always for transparent hugepage (never makes no sense, other than for debugging purposes, madvise already provides the guarantee of zero risk of unintentional and not guaranteed beneficial memory waste). > Will keep it in mind. It's taking the anon_vma lock but once again, > there might be more than one anon_vma to worry about and the proper > locking still isn't massively clear to me. Yes, that's my point, same issue there. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org