From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with SMTP id CF35B6B01F2 for ; Tue, 27 Apr 2010 22:07:30 -0400 (EDT) Date: Wed, 28 Apr 2010 03:44:34 +0200 From: Andrea Arcangeli Subject: Re: [PATCH 3/3] mm,migration: Remove straggling migration PTEs when page tables are being moved after the VMA has already moved Message-ID: <20100428014434.GM510@random.random> References: <1272403852-10479-1-git-send-email-mel@csn.ul.ie> <1272403852-10479-4-git-send-email-mel@csn.ul.ie> <20100427223004.GF8860@random.random> <20100427225852.GH8860@random.random> <20100428102928.a3b25066.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100428102928.a3b25066.kamezawa.hiroyu@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org To: KAMEZAWA Hiroyuki Cc: Mel Gorman , Linux-MM , LKML , Minchan Kim , Christoph Lameter , Rik van Riel , Andrew Morton List-ID: On Wed, Apr 28, 2010 at 10:29:28AM +0900, KAMEZAWA Hiroyuki wrote: > Hmm..Mel's patch 2/3 takes vma->anon_vma->lock in vma_adjust(), > so this patch clears vma->anon_vma... yep, it should be safe with patch 2 applied too. And I'm unsure why Mel's patch locks the anon_vma also when vm_start != start. See the other email I sent about patch 2. > I think we can unlock this just after move_page_tables(). Checking this, I can't see where exactly is vma->vm_pgoff adjusted during the atomic section I protected with the anon_vma->lock? For a moment it looks like these pages become unmovable. I guess this is why I thought initially that it was move_page_tables to adjust the page->index. If it doesn't then the vma->vm_pgoff has to be moved down of shift >>PAGE_SHIFT and it doesn't seem to be happening which is an unrelated bug. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org