Re: Transparent Hugepage Support #22

[Andrea Arcangeli <aarcange@redhat.com>]

On Fri, Apr 30, 2010 at 10:54:27AM +0200, Ingo Molnar wrote:
> It would be nice and informative to have two diffstats in the announcement:
> 
> - an 'absolute' one that shows all the hugetlb changes relative to upstream 
>   (or relative to -mm, whichever tree you use as a base),

That's easy, I will do next times. I'm based on mainline right now.

> - and [if possible] a 'delta' one that shows the diffstat to the previous
>   version you've announced. [say in this current case the #21..#22 delta 
>   diffstat] [this might not always be easy to provide, when the upstream base 
>   changes.]

I've revision control on the quilt patchset, I can send the diffstat
of the quilt patchset.

You can also monitor the changes by running:

git fetch
git diff origin/master

before "git checkout origin/master".

but as you said that will also show the new mainline changes mixed
with my changes.

> That way people can see the general direction and scope from the email, 
> without having to fetch any of the trees.

It's informative yes, but I hope that people really fetch the tree,
review the changes with "git log -p" or just blind test it and run
some benchmark. Many already did and that is the only way to get
feedback (positive or negative) and to be sure that we're going into
the right direction. The only feedback I got so far from people
testing the tree has been exceedingly positive which in addition to
the benchmarks I run myself, makes me more confident this is going in
the right direction and helping a wider scope of workloads. The
research I did initially on the prefault logic I think helped me
keeping things simpler and more efficient and I think the decision
that it was worth it do larger copy-page/clear-page only if we also
get something more than a prefault speedup in return (as those copies
slowdown the page faults and trashes the cache) is paying off.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>