From: Shaohui Zheng <shaohui.zheng@intel.com>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: Greg KH <gregkh@suse.de>,
akpm@linux-foundation.org, linux-mm@kvack.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Andi Kleen <ak@linux.intel.com>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-kernel@vger.kernel.org, haicheng.li@linux.intel.com,
shaohui.zheng@linux.intel.com
Subject: Re: [RFC, 6/7] NUMA hotplug emulator
Date: Fri, 14 May 2010 10:08:11 +0800 [thread overview]
Message-ID: <20100514020811.GD4381@shaohui> (raw)
In-Reply-To: <20100514020526.GB7678@localhost>
On Fri, May 14, 2010 at 10:05:26AM +0800, Wu Fengguang wrote:
> On Fri, May 14, 2010 at 09:49:02AM +0800, Zheng, Shaohui wrote:
> > On Thu, May 13, 2010 at 09:56:03AM -0700, Greg KH wrote:
> > > On Thu, May 13, 2010 at 08:00:16PM +0800, Shaohui Zheng wrote:
> > > > hotplug emulator:extend memory probe interface to support NUMA
> > > >
> > > > Extend memory probe interface to support an extra paramter nid,
> > > > the reserved memory can be added into this node if node exists.
> > > >
> > > > Add a memory section(128M) to node 3(boots with mem=1024m)
> > > >
> > > > echo 0x40000000,3 > memory/probe
> > > >
> > > > And more we make it friendly, it is possible to add memory to do
> > > >
> > > > echo 3g > memory/probe
> > > > echo 1024m,3 > memory/probe
> > > >
> > > > It maintains backwards compatibility.
> > >
> > > Again, please document this.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > okay
>
> Shaohui, it's useless to document a wrong interface.
> Better to fix the interface _first_, then document becomes meaningful.
Fenggunag,
greg reminds me to add the docment into Documentation/ABI/, We miss it in
the RFC. Currently, the interface format is not finalized, when we decide the
final interface, the last step is documenting it in.
>
> Thanks,
> Fengguang
--
Thanks & Regards,
Shaohui
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-05-14 2:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 12:00 [RFC, 6/7] NUMA hotplug emulator Shaohui Zheng
2010-05-13 16:56 ` Greg KH
2010-05-13 18:02 ` Dave Hansen
2010-05-13 18:15 ` Greg KH
2010-05-13 18:49 ` Dave Hansen
2010-05-13 18:58 ` Greg KH
2010-05-13 19:16 ` Dave Hansen
2010-05-13 19:21 ` Greg KH
2010-05-18 5:41 ` Shaohui Zheng
2010-05-18 7:27 ` Dave Hansen
2010-05-18 7:56 ` Shaohui Zheng
2010-05-18 8:55 ` Andi Kleen
2010-05-18 15:46 ` Dave Hansen
2010-05-18 7:44 ` Nicholas A. Bellinger
2010-05-18 7:44 ` Paul Mundt
2010-05-18 8:08 ` Shaohui Zheng
2010-05-14 1:49 ` Shaohui Zheng
2010-05-14 2:05 ` Wu Fengguang
2010-05-14 2:08 ` Shaohui Zheng [this message]
2010-05-21 10:11 ` Ankita Garg
2010-05-24 1:26 ` Shaohui Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100514020811.GD4381@shaohui \
--to=shaohui.zheng@intel.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=gregkh@suse.de \
--cc=haicheng.li@linux.intel.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=shaohui.zheng@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).