linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Lameter <cl@linux.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: linux-mm@kvack.org
Subject: [RFC SLEB 10/10] SLEB: Add shared cache
Date: Fri, 14 May 2010 13:39:18 -0500	[thread overview]
Message-ID: <20100514183947.800937046@quilx.com> (raw)
In-Reply-To: 20100514183908.118952419@quilx.com

[-- Attachment #1: sled_shared_static --]
[-- Type: text/plain, Size: 2790 bytes --]

Add support for a shared cache like SLAB

Signed-off-by: Christoph Lameter <cl@linux-foundation.org>

---
 include/linux/slub_def.h |    3 +++
 mm/slub.c                |   41 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 44 insertions(+)

Index: linux-2.6/include/linux/slub_def.h
===================================================================
--- linux-2.6.orig/include/linux/slub_def.h	2010-04-29 16:18:22.000000000 -0500
+++ linux-2.6/include/linux/slub_def.h	2010-04-29 16:18:54.000000000 -0500
@@ -55,6 +55,9 @@ struct kmem_cache_node {
 	atomic_long_t total_objects;
 	struct list_head full;
 #endif
+	int objects;
+	spinlock_t shared_lock;
+	void *object[BOOT_QUEUE_SIZE];
 };
 
 /*
Index: linux-2.6/mm/slub.c
===================================================================
--- linux-2.6.orig/mm/slub.c	2010-04-29 16:18:43.000000000 -0500
+++ linux-2.6/mm/slub.c	2010-04-29 16:18:54.000000000 -0500
@@ -1418,6 +1418,22 @@ static struct page *get_partial(struct k
 void drain_objects(struct kmem_cache *s, void **object, int nr)
 {
 	int i;
+	struct kmem_cache_node *n = get_node(s, numa_node_id());
+
+	/* First drain to shared cache if its there */
+	if (n->objects < BOOT_QUEUE_SIZE) {
+		int d;
+
+		spin_lock(&n->shared_lock);
+		d = min(nr, BOOT_QUEUE_SIZE - n->objects);
+		if (d > 0) {
+			memcpy(n->object + n->objects, object, d * sizeof(void *));
+			n->objects += d;
+			nr -= d;
+			object += d;
+		}
+		spin_unlock(&n->shared_lock);
+	}
 
 	for (i = 0 ; i < nr; ) {
 
@@ -1697,6 +1713,29 @@ redo:
 		if (unlikely(!node_match(c, node))) {
 			flush_cpu_objects(s, c);
 			c->node = node;
+		} else {
+			struct kmem_cache_node *n = get_node(s, c->node);
+
+			/*
+			 * Node specified is matching the stuff that we cache,
+			 * so we could retrieve objects from the shared cache
+			 * of the indicated node if there would be anything
+			 * there.
+			 */
+			if (n->objects) {
+				int d;
+
+				spin_lock(&n->shared_lock);
+				d = min(min(s->batch, BOOT_QUEUE_SIZE), n->objects);
+				if (d > 0) {
+					memcpy(c->object + c->objects,
+						n->object + n->objects - d,
+						d * sizeof(void *));
+					n->objects -= d;
+					c->objects += d;
+				}
+				spin_unlock(&n->shared_lock);
+			}
 		}
 
 		while (c->objects < s->batch) {
@@ -2033,6 +2072,8 @@ init_kmem_cache_node(struct kmem_cache_n
 	atomic_long_set(&n->total_objects, 0);
 	INIT_LIST_HEAD(&n->full);
 #endif
+	spin_lock_init(&n->shared_lock);
+	n->objects = 0;
 }
 
 static DEFINE_PER_CPU(struct kmem_cache_cpu, kmalloc_percpu[KMALLOC_CACHES]);

-- 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      parent reply	other threads:[~2010-05-14 18:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-14 18:39 [RFC SLEB 00/10] [RFC] SLEB: The Enhanced Slab Allocator Christoph Lameter
2010-05-14 18:39 ` [RFC SLEB 01/10] slab: Introduce a constant for a unspecified node Christoph Lameter
2010-05-14 18:39 ` [RFC SLEB 02/10] SLUB: Constants need UL Christoph Lameter
2010-05-14 18:39 ` [RFC SLEB 03/10] SLUB: Use kmem_cache flags to detect if Slab is in debugging mode Christoph Lameter
2010-05-14 18:39 ` [RFC SLEB 04/10] SLUB: discard_slab_unlock Christoph Lameter
2010-05-14 18:39 ` [RFC SLEB 05/10] SLUB: is_kmalloc_cache Christoph Lameter
2010-05-14 18:39 ` [RFC SLEB 06/10] SLEB: The Enhanced Slab Allocator Christoph Lameter
2010-05-14 18:39 ` [RFC SLEB 07/10] SLEB: Resize cpu queue Christoph Lameter
2010-05-14 18:39 ` [RFC SLEB 08/10] SLED: Get rid of useless function Christoph Lameter
2010-05-14 18:39 ` [RFC SLEB 09/10] SLEB: Remove MAX_OBJS limitation Christoph Lameter
2010-05-14 18:39 ` Christoph Lameter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100514183947.800937046@quilx.com \
    --to=cl@linux.com \
    --cc=linux-mm@kvack.org \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).