From: Nick Piggin <npiggin@suse.de>
To: Christoph Lameter <cl@linux.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Pierre Tardy <tardyp@gmail.com>, Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Tom Zanussi <tzanussi@gmail.com>,
Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org, arjan@infradead.org,
ziga.mahkovec@gmail.com, davem <davem@davemloft.net>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Tejun Heo <tj@kernel.org>, Jens Axboe <jens.axboe@oracle.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: Unexpected splice "always copy" behavior observed
Date: Wed, 19 May 2010 02:13:08 +1000 [thread overview]
Message-ID: <20100518161308.GL2516@laptop> (raw)
In-Reply-To: <20100518160051.GK2516@laptop>
On Wed, May 19, 2010 at 02:00:51AM +1000, Nick Piggin wrote:
> On Tue, May 18, 2010 at 10:56:24AM -0500, Christoph Lameter wrote:
> > On Wed, 19 May 2010, Nick Piggin wrote:
> >
> > > What would be needed is to have filesystem maintainers go through and
> > > enable it on a case by case basis. It's trivial for tmpfs/ramfs type
> > > filesystems and I have a patch for those, but I never posted it on.yet.
> > > Even basic buffer head filesystems IIRC get a little more complex --
> > > but we may get some milage just out of invalidating the existing
> > > pagecache rather than getting fancy and trying to move buffers over
> > > to the new page.
> >
> > There is a "migration" address space operation for moving pages. Page
> > migration requires that in order to be able to move dirty pages. Can
> > splice use that?
>
> Hmm yes I didn't think of that, it probably could.
It's not the only requirement, of course, just that it could
potentially reuse some of the code.
The big difference is that the source page is already dirty, and
the destination page might not exist, might exist and be partially
uptodate, not have blocks allocated, might be past i_size, fully
uptodate, etc.
So it's more than a matter of just a simple copy to another page
and taking over exactly the same filesystem state as the old page.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-05-18 16:13 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-18 15:34 Unexpected splice "always copy" behavior observed Mathieu Desnoyers
2010-05-18 15:51 ` Nick Piggin
2010-05-18 15:56 ` Christoph Lameter
2010-05-18 16:00 ` Nick Piggin
2010-05-18 16:13 ` Nick Piggin [this message]
2010-05-18 15:53 ` Steven Rostedt
2010-05-18 16:10 ` Steven Rostedt
2010-05-18 16:25 ` Linus Torvalds
2010-05-19 6:31 ` Nick Piggin
2010-05-19 14:39 ` Linus Torvalds
2010-05-19 14:56 ` Steven Rostedt
2010-05-19 14:59 ` Linus Torvalds
2010-05-19 15:12 ` Steven Rostedt
2010-05-19 15:51 ` Mathieu Desnoyers
2010-05-19 15:33 ` Miklos Szeredi
2010-05-19 15:45 ` Steven Rostedt
2010-05-19 15:55 ` Nick Piggin
2010-05-19 16:01 ` Mathieu Desnoyers
2010-05-19 16:36 ` Steven Rostedt
2010-05-19 15:57 ` Mathieu Desnoyers
2010-05-19 16:27 ` Nick Piggin
2010-05-19 19:14 ` Mathieu Desnoyers
2010-05-19 19:31 ` Linus Torvalds
2010-05-19 21:49 ` Mathieu Desnoyers
2010-05-20 0:04 ` Linus Torvalds
2010-05-20 1:56 ` Mathieu Desnoyers
2010-05-20 14:18 ` Linus Torvalds
2010-05-19 20:59 ` Rick Sherm
2010-05-19 15:17 ` Nick Piggin
2010-05-19 15:30 ` Linus Torvalds
2010-05-19 15:44 ` Nick Piggin
2010-05-19 15:28 ` Miklos Szeredi
2010-05-19 15:32 ` Linus Torvalds
2010-05-19 15:56 ` Miklos Szeredi
2010-05-19 16:01 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100518161308.GL2516@laptop \
--to=npiggin@suse.de \
--cc=acme@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=cl@linux.com \
--cc=davem@davemloft.net \
--cc=fweisbec@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tardyp@gmail.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tzanussi@gmail.com \
--cc=ziga.mahkovec@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).