From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail190.messagelabs.com (mail190.messagelabs.com [216.82.249.51]) by kanga.kvack.org (Postfix) with ESMTP id 0613F60032A for ; Fri, 21 May 2010 19:03:05 -0400 (EDT) Date: Fri, 21 May 2010 16:02:40 -0700 From: Andrew Morton Subject: Re: [PATCH 3/7] numa-x86_64-use-generic-percpu-var-numa_node_id-implementation-fix1 Message-Id: <20100521160240.b61d3404.akpm@linux-foundation.org> In-Reply-To: <20100503150518.15039.3576.sendpatchset@localhost.localdomain> References: <20100503150455.15039.10178.sendpatchset@localhost.localdomain> <20100503150518.15039.3576.sendpatchset@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Lee Schermerhorn Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-numa@vger.kernel.org, Tejun Heo , Valdis.Kletnieks@vt.edu, Randy Dunlap , Christoph Lameter , eric.whitney@hp.com, KAMEZAWA Hiroyuki List-ID: On Mon, 03 May 2010 11:05:18 -0400 Lee Schermerhorn wrote: > Incremental patch 1 to > numa-x86_64-use-generic-percpu-var-numa_node_id-implementation.patch > in 28apr10 mmotm. > > Use generic percpu numa_node variable only for x86_64. > > x86_32 will require separate support. Not sure it's worth it. > > Signed-off-by: Lee Schermerhorn > > arch/x86/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6.34-rc5-mmotm-100428-1653/arch/x86/Kconfig > =================================================================== > --- linux-2.6.34-rc5-mmotm-100428-1653.orig/arch/x86/Kconfig > +++ linux-2.6.34-rc5-mmotm-100428-1653/arch/x86/Kconfig > @@ -1720,7 +1720,7 @@ config HAVE_ARCH_EARLY_PFN_TO_NID > depends on NUMA > > config USE_PERCPU_NUMA_NODE_ID > - def_bool y > + def_bool X86_64 > depends on NUMA > > menu "Power management and ACPI options" i386 allmodconfig: In file included from include/linux/gfp.h:7, from include/linux/kmod.h:22, from include/linux/module.h:13, from include/linux/crypto.h:21, from arch/x86/kernel/asm-offsets_32.c:7, from arch/x86/kernel/asm-offsets.c:2: include/linux/topology.h: In function 'numa_node_id': include/linux/topology.h:248: error: implicit declaration of function 'cpu_to_node' this patchset has been quite a PITA. What happened? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org