Re: [PATCH] tmpfs: Insert tmpfs cache pages to inactive list at first

[Andrew Morton <akpm@linux-foundation.org>]

On Sat, 22 May 2010 09:04:30 +0900 (JST) KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:

> > > -static inline void lru_cache_add_active_anon(struct page *page)
> > > -{
> > > -	__lru_cache_add(page, LRU_ACTIVE_ANON);
> > > -}
> > > -
> > >  static inline void lru_cache_add_file(struct page *page)
> > >  {
> > >  	__lru_cache_add(page, LRU_INACTIVE_FILE);
> > >  }
> > >  
> > > -static inline void lru_cache_add_active_file(struct page *page)
> > > -{
> > > -	__lru_cache_add(page, LRU_ACTIVE_FILE);
> > > -}
> > 
> > Did you intend to remove these two functions?
> 
> This is for applying Hannes's commnet.
> 
> > They do appear to be unused now, but they still make sense and might be
> > used in the future, perhaps.  
> 
> Personally, I don't like the strategy that anyone without me might
> use this function in the future. because It often never come.
> 
> > It's OK to remove them, but I'm wondering
> > if it was deliberately included in this patch?
> 
> Makes sense.
> OK, please drop current patch at once. I'll post V2.

Is OK, let's keep the change.  I just wanted to check that it wasn't
made accidentally.  

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>