Re: [RFC, 3/7] NUMA hotplug emulator

[Shaohui Zheng <shaohui.zheng@intel.com>]

On Fri, May 21, 2010 at 03:38:16PM +0530, Ankita Garg wrote:
> Hi,
> 
> On Thu, May 13, 2010 at 07:48:35PM +0800, Shaohui Zheng wrote:
> > Userland interface to hotplug-add fake offlined nodes.
> > 
> > Add a sysfs entry "probe" under /sys/devices/system/node/:
> > 
> >  - to show all fake offlined nodes:
> >     $ cat /sys/devices/system/node/probe
> > 
> >  - to hotadd a fake offlined node, e.g. nodeid is N:
> >     $ echo N > /sys/devices/system/node/probe
> > 
> > Signed-off-by: Haicheng Li <haicheng.li@linux.intel.com>
> > Signed-off-by: Shaohui Zheng <shaohui.zheng@intel.com>
> > ---
> > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> > index 9458685..2c078c8 100644
> > --- a/arch/x86/Kconfig
> > +++ b/arch/x86/Kconfig
> > @@ -1214,6 +1214,20 @@ config NUMA_EMU
> >  	  into virtual nodes when booted with "numa=fake=N", where N is the
> >  	  number of nodes. This is only useful for debugging.
> > 
> > +config NUMA_HOTPLUG_EMU
> > +	bool "NUMA hotplug emulator"
> > +	depends on X86_64 && NUMA && HOTPLUG
> > +	---help---
> > +
> > +config NODE_HOTPLUG_EMU
> > +	bool "Node hotplug emulation"
> > +	depends on NUMA_HOTPLUG_EMU && MEMORY_HOTPLUG
> > +	---help---
> > +	  Enable Node hotplug emulation. The machine will be setup with
> > +	  hidden virtual nodes when booted with "numa=hide=N*size", where
> > +	  N is the number of hidden nodes, size is the memory size per
> > +	  hidden node. This is only useful for debugging.
> > +
> 
> The above dependencies do not work as expected. I could configure
> NUMA_HOTPLUG_EMU & NODE_HOTPLUG_EMU without having MEMORY_HOTPLUG
> turned on. By pushing the above definition below SPARSEMEM and memory
> hot add and remove, the dependencies could be sorted out.
Ankita, 
	The emulation code was tested by many times, but we did not try each 
combination for the new options, good catching.
    We will includes your suggestion in the formal patch. thanks so much.
> 
> -- 
> Regards,                                                                        
> Ankita Garg (ankita@in.ibm.com)                                                 
> Linux Technology Center                                                         
> IBM India Systems & Technology Labs,                                            
> Bangalore, India

-- 
Thanks & Regards,
Shaohui

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>