From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
linux-mm@kvack.org,
Michael Monnerie <michael.monnerie@is.it-management.at>
Subject: Re: [PATCH (resend)] xfs: don't allow recursion into fs under write_begin
Date: Tue, 25 May 2010 06:33:17 -0400 [thread overview]
Message-ID: <20100525103317.GB2864@infradead.org> (raw)
In-Reply-To: <4BF8056E.8080900@sandeen.net>
On Sat, May 22, 2010 at 11:25:18AM -0500, Eric Sandeen wrote:
> Michael Monnerie reported this fantastic stack overflow:
> I don't think we can afford to let write_begin recurse into the fs,
> so we can set AOP_FLAG_NOFS ... is this too big a hammer?
I don't really like it. There's nothing XFS-specific here - it's the
same problem with direct reclaim calling back into the FS and causing
massive amounts of problems. If we want to fix this class of problems
we just need to do the same thing ext4 and btrfs already do and refuse
to call the allocator from reclaim context.
Just curious, how much stack does the path up to generic_perform_write
use?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2010-05-25 10:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-22 16:25 [PATCH (resend)] xfs: don't allow recursion into fs under write_begin Eric Sandeen
2010-05-25 10:33 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100525103317.GB2864@infradead.org \
--to=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=michael.monnerie@is.it-management.at \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).