From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: writeback hang in current mainline
Date: Wed, 26 May 2010 15:42:08 +0200 [thread overview]
Message-ID: <20100526134208.GA2557@lst.de> (raw)
In-Reply-To: <20100526125614.GM23411@kernel.dk>
On Wed, May 26, 2010 at 02:56:15PM +0200, Jens Axboe wrote:
> On Wed, May 26 2010, Christoph Hellwig wrote:
> > On Wed, May 26, 2010 at 02:21:26PM +0200, Jens Axboe wrote:
> > > Ugh ok I see it, I had the caller_frees reverted. Try this :-)
> >
> > This seems to fix it. Running some more tests now.
>
> Goodie, then the analysis at least is correct. A potentially cleaner fix
> would be to just allocate the WB_SYNC_NONE && sb_pinned work struct on
> the stack, since then we can get rid of that nastiness in
> wb_work_complete() as well (and not pass 'sb_pinned' around so much).
>
> If you have time, care to test this one as well?
Both this and the previous one hang hard in xfstests 007, with no chance
of getting a backtrace.
For now I would recommend to revert
21c12849fef73efc9a898b6702fe421fd774f515 and
29c795f02e68ecd7bb1374844d3e55e882ac158f,
which makes xfstests run fine for me.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-05-26 13:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 11:13 writeback hang in current mainline Christoph Hellwig
2010-05-26 11:21 ` Jens Axboe
2010-05-26 11:40 ` Christoph Hellwig
2010-05-26 11:49 ` Jens Axboe
2010-05-26 12:08 ` Christoph Hellwig
2010-05-26 12:21 ` Jens Axboe
2010-05-26 12:45 ` Christoph Hellwig
2010-05-26 12:56 ` Jens Axboe
2010-05-26 13:42 ` Christoph Hellwig [this message]
2010-05-26 13:44 ` Jens Axboe
2010-05-26 13:45 ` Jens Axboe
2010-05-26 13:56 ` Christoph Hellwig
2010-05-26 17:18 ` Jens Axboe
2010-05-26 17:43 ` Christoph Hellwig
2010-05-26 17:47 ` Jens Axboe
2010-05-26 19:18 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100526134208.GA2557@lst.de \
--to=hch@lst.de \
--cc=jens.axboe@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).