From: Jens Axboe <jens.axboe@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: writeback hang in current mainline
Date: Wed, 26 May 2010 19:47:54 +0200 [thread overview]
Message-ID: <20100526174753.GU23411@kernel.dk> (raw)
In-Reply-To: <20100526174310.GA12286@lst.de>
On Wed, May 26 2010, Christoph Hellwig wrote:
> On Wed, May 26, 2010 at 07:18:15PM +0200, Jens Axboe wrote:
> > OK. From your previous mail:
> >
> > For now I would recommend to revert
> > 21c12849fef73efc9a898b6702fe421fd774f515 and
> > 29c795f02e68ecd7bb1374844d3e55e882ac158f,
> > which makes xfstests run fine for me.
> >
> > Just to ensure we are on the same page, what commits are these? They are
> > not valid shas in Linus' tree. Did you mean
>
> Sorry, those were my local revert commits.
>
> >
> > e913fc825dc685a444cb4c1d0f9d32f372f59861
> > 7c8a3554c683f512dbcee26faedb42e4c05f12fa
>
> Exactly!
Makes sense then. So the change from those commits (with the fixes from
today) ensures that we properly do WB_SYNC_NONE writeback when
sb->s_umount is held instead of just skipping those inodes. The question
is, is that exposing some other bug or is the code still buggy...
You said that you could not get a backtrace when the test hung, were you
able to get anything out of it?
--
Jens Axboe
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-05-26 17:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 11:13 writeback hang in current mainline Christoph Hellwig
2010-05-26 11:21 ` Jens Axboe
2010-05-26 11:40 ` Christoph Hellwig
2010-05-26 11:49 ` Jens Axboe
2010-05-26 12:08 ` Christoph Hellwig
2010-05-26 12:21 ` Jens Axboe
2010-05-26 12:45 ` Christoph Hellwig
2010-05-26 12:56 ` Jens Axboe
2010-05-26 13:42 ` Christoph Hellwig
2010-05-26 13:44 ` Jens Axboe
2010-05-26 13:45 ` Jens Axboe
2010-05-26 13:56 ` Christoph Hellwig
2010-05-26 17:18 ` Jens Axboe
2010-05-26 17:43 ` Christoph Hellwig
2010-05-26 17:47 ` Jens Axboe [this message]
2010-05-26 19:18 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100526174753.GU23411@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).