From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with ESMTP id 22F086B01AD for ; Thu, 3 Jun 2010 14:12:41 -0400 (EDT) Date: Thu, 3 Jun 2010 11:11:25 -0700 From: Andrew Morton Subject: Re: [PATCH] hugetlb: call mmu notifiers on hugepage cow Message-Id: <20100603111125.8cd6a787.akpm@linux-foundation.org> In-Reply-To: <4C07E800.5010701@cray.com> References: <4BFED954.8060807@cray.com> <20100601231600.3b3bf499.akpm@linux-foundation.org> <4C06E5A6.6@cray.com> <20100602163346.b8f8b8a4.akpm@linux-foundation.org> <4C07E800.5010701@cray.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Doug Doan Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "andi@firstfloor.org" , "lee.schermerhorn@hp.com" , "rientjes@google.com" , "mel@csn.ul.ie" , Andrea Arcangeli List-ID: On Thu, 3 Jun 2010 10:36:00 -0700 Doug Doan wrote: > > Well, specifically it means that > > mmu_notifier_invalidate_range_start/end() implemetnations can no longer > > take page_table_lock or any lock which nests outside page_table_lock. > > That lessens flexibility. > > > > As the other mmu_notifier_invalidate_range_start/end() callsite in this > > function carefully nested those calls outside page_table_lock, perhaps > > that was thought to be a significant thing. > > Here's my rationale: for the normal page case, the invalidation call is done > inside a page_table_lock, It is? Where does that happen? > so the same should also be done in the huge page case. > Does it really make sense to call invalidation on one hugepage and have another > call invalidate the same hugepage while the first call is still not finished? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org