From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with SMTP id DD2B16B01B0 for ; Thu, 3 Jun 2010 18:02:29 -0400 (EDT) Date: Fri, 4 Jun 2010 00:01:03 +0200 From: Oleg Nesterov Subject: Re: [PATCH 08/12] oom: dump_tasks() use find_lock_task_mm() too Message-ID: <20100603220103.GA8511@redhat.com> References: <20100603135106.7247.A69D9226@jp.fujitsu.com> <20100603152350.725F.A69D9226@jp.fujitsu.com> <20100603152652.GA8743@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org To: David Rientjes Cc: KOSAKI Motohiro , "Luis Claudio R. Goncalves" , LKML , linux-mm , Andrew Morton , KAMEZAWA Hiroyuki , Nick Piggin List-ID: On 06/03, David Rientjes wrote: > > On Thu, 3 Jun 2010, Oleg Nesterov wrote: > > > (off-topic) > > > > out_of_memory() calls dump_header()->dump_tasks() lockless, we > > need tasklist. forgot to mention, __out_of_memory() too. > Already fixed in my rewrite patchset, as most of these things are. Sigh. In 3/18, without any note in the changelog. Another minor thing which can be fixed before rewrite. And please note that it was me who pointed out we need tasklist during the previous discussion. I'd suggest you to send a separate patch on top of Kosaki's patches. OK, this is boring ;) I am going to ignore everything except technical issues in this thread. Oleg. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org