From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with SMTP id 04D616B01C8 for ; Tue, 8 Jun 2010 14:43:26 -0400 (EDT) Date: Tue, 8 Jun 2010 20:41:44 +0200 From: Oleg Nesterov Subject: Re: [PATCH 08/10] oom: use send_sig() instead force_sig() Message-ID: <20100608184144.GA5914@redhat.com> References: <20100608204621.767A.A69D9226@jp.fujitsu.com> <20100608210000.7692.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100608210000.7692.A69D9226@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org To: KOSAKI Motohiro Cc: "Luis Claudio R. Goncalves" , LKML , linux-mm , David Rientjes , Andrew Morton , KAMEZAWA Hiroyuki , Nick Piggin , Minchan Kim List-ID: On 06/08, KOSAKI Motohiro wrote: > > Oleg pointed out oom_kill.c has force_sig() abuse. force_sig() mean > ignore signal mask. but SIGKILL itself is not maskable. Yes. And we have other reasons to avoid force_sig(). It should be used only for synchronous signals. But, > @@ -399,7 +399,7 @@ static int __oom_kill_process(struct task_struct *p, struct mem_cgroup *mem) > p->rt.time_slice = HZ; > set_tsk_thread_flag(p, TIF_MEMDIE); > > - force_sig(SIGKILL, p); > + send_sig(SIGKILL, p, 1); This is not right, we need send_sig(SIGKILL, p, 0). Better yet, send_sig_info(SIGKILL, SEND_SIG_NOINFO). I think send_sig() should die. The reason is that si_fromuser() must be true, otherwise we can't kill the SIGNAL_UNKILLABLE (sub-namespace inits) tasks. Oh. This reminds me, we really need the trivial (but annoying) cleanups here. The usage of SEND_SIG_ constants is messy, and they should be renamed at least. And in fact, we need the new one which acts like SEND_SIG_FORCED but si_fromuser(). We do not want to allocate the memory when the caller is oom_kill or zap_pid_ns_processes(). OK. I'll send the simple patch which adds the new helper with the comment. send_sigkill() or kernel_kill_task(), or do you see a better name? Oleg. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org