From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with SMTP id A286C6B01DE for ; Tue, 8 Jun 2010 16:19:06 -0400 (EDT) Date: Tue, 8 Jun 2010 22:17:39 +0200 From: Oleg Nesterov Subject: Re: [patch 02/18] oom: introduce find_lock_task_mm() to fix !mm false positives Message-ID: <20100608201739.GA11028@redhat.com> References: <20100608124246.9258ccab.akpm@linux-foundation.org> <20100608201403.GA10264@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100608201403.GA10264@redhat.com> Sender: owner-linux-mm@kvack.org To: Andrew Morton Cc: David Rientjes , Rik van Riel , Nick Piggin , Balbir Singh , KAMEZAWA Hiroyuki , KOSAKI Motohiro , linux-mm@kvack.org List-ID: On 06/08, Oleg Nesterov wrote: > > On 06/08, Andrew Morton wrote: > > > > > - /* skip tasks that have already released their mm */ > > > - if (!p->mm) > > > - continue; > > We shouldn't remove this without removing OR updating the PF_EXITING check > below. That is why we had another patch. > > This change alone allows to trivially disable oom-kill. If we have a process > with the dead leader, select_bad_process() will always return -1. > > We either need another patch from Kosaki's series > > - if (p->flags & PF_EXITING) > + if (p->flags & PF_EXITING && p->mm) OOPS, sorry. I didn't understand you are going to merge this change too. Probably oom-pf_exiting-check-should-take-mm-into-account.patch should go ahead of this one for bisecting. Oleg. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org