From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with ESMTP id 4C132620089 for ; Tue, 15 Jun 2010 12:54:39 -0400 (EDT) Date: Tue, 15 Jun 2010 12:54:23 -0400 From: Christoph Hellwig Subject: Re: [RFC PATCH 0/6] Do not call ->writepage[s] from direct reclaim and use a_ops->writepages() where possible Message-ID: <20100615165423.GA16868@infradead.org> References: <1275987745-21708-1-git-send-email-mel@csn.ul.ie> <20100615140011.GD28052@random.random> <20100615141122.GA27893@infradead.org> <20100615142219.GE28052@random.random> <20100615144342.GA3339@infradead.org> <20100615150850.GF28052@random.random> <20100615152526.GA3468@infradead.org> <20100615154516.GG28052@random.random> <20100615162600.GA9910@infradead.org> <4C17AF2D.2060904@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C17AF2D.2060904@redhat.com> Sender: owner-linux-mm@kvack.org To: Rik van Riel Cc: Christoph Hellwig , Andrea Arcangeli , Mel Gorman , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Dave Chinner , Chris Mason , Nick Piggin List-ID: On Tue, Jun 15, 2010 at 12:49:49PM -0400, Rik van Riel wrote: > This is already in a filesystem. Why does ->writepage get > called a second time? Shouldn't this have a gfp_mask > without __GFP_FS set? Why would it? GFP_NOFS is not for all filesystem code, but only for code where we can't re-enter the filesystem due to deadlock potential. Except for a few filesystems that have transactions open inside ->aio_write no one uses GFP_NOFS from that path. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org