From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with ESMTP id 72AC16B024D for ; Thu, 22 Jul 2010 01:31:18 -0400 (EDT) Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235]) by e8.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id o6M5TBol000438 for ; Thu, 22 Jul 2010 01:29:11 -0400 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o6M5VG05271822 for ; Thu, 22 Jul 2010 01:31:16 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id o6M5VFv8022064 for ; Thu, 22 Jul 2010 01:31:16 -0400 Date: Thu, 22 Jul 2010 11:01:13 +0530 From: Balbir Singh Subject: Re: [PATCH 1/7] memcg: sc.nr_to_reclaim should be initialized Message-ID: <20100722053113.GL14369@balbir.in.ibm.com> Reply-To: balbir@linux.vnet.ibm.com References: <20100716191006.7369.A69D9226@jp.fujitsu.com> <20100716191256.736C.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20100716191256.736C.A69D9226@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org To: KOSAKI Motohiro Cc: LKML , linux-mm , Andrew Morton , Mel Gorman , KAMEZAWA Hiroyuki , Nishimura Daisuke List-ID: * KOSAKI Motohiro [2010-07-16 19:13:31]: > Currently, mem_cgroup_shrink_node_zone() initialize sc.nr_to_reclaim as 0. > It mean shrink_zone() only scan 32 pages and immediately return even if > it doesn't reclaim any pages. > > This patch fixes it. > > Signed-off-by: KOSAKI Motohiro > --- > mm/vmscan.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 1691ad0..bd1d035 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1932,6 +1932,7 @@ unsigned long mem_cgroup_shrink_node_zone(struct mem_cgroup *mem, > struct zone *zone, int nid) > { > struct scan_control sc = { > + .nr_to_reclaim = SWAP_CLUSTER_MAX, > .may_writepage = !laptop_mode, > .may_unmap = 1, > .may_swap = !noswap, Could you please do some additional testing on 1. How far does this push pages (in terms of when limit is hit)? 2. Did you hit a problem with the current setting or is it a review fix? -- Three Cheers, Balbir -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org