linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Lameter <cl@linux-foundation.org>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: linux-mm@kvack.org, David Rientjes <rientjes@google.com>
Subject: [S+Q Cleanup3 1/6] Slub: Force no inlining of debug functions
Date: Thu, 19 Aug 2010 15:33:25 -0500	[thread overview]
Message-ID: <20100819203437.031478257@linux.com> (raw)
In-Reply-To: 20100819203324.549566024@linux.com

[-- Attachment #1: slub_nolinline --]
[-- Type: text/plain, Size: 1407 bytes --]

Compiler folds the debgging functions into the critical paths.
Avoid that by adding noinline to the functions that check for
problems.

Acked-by: David Rientjes <rientjes@google.com>
Signed-off-by: Christoph Lameter <cl@linux.com>

---
 mm/slub.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Index: linux-2.6/mm/slub.c
===================================================================
--- linux-2.6.orig/mm/slub.c	2010-08-19 14:13:02.000000000 -0500
+++ linux-2.6/mm/slub.c	2010-08-19 14:13:05.000000000 -0500
@@ -862,7 +862,7 @@ static void setup_object_debug(struct km
 	init_tracking(s, object);
 }
 
-static int alloc_debug_processing(struct kmem_cache *s, struct page *page,
+static noinline int alloc_debug_processing(struct kmem_cache *s, struct page *page,
 					void *object, unsigned long addr)
 {
 	if (!check_slab(s, page))
@@ -902,8 +902,8 @@ bad:
 	return 0;
 }
 
-static int free_debug_processing(struct kmem_cache *s, struct page *page,
-					void *object, unsigned long addr)
+static noinline int free_debug_processing(struct kmem_cache *s,
+		 struct page *page, void *object, unsigned long addr)
 {
 	if (!check_slab(s, page))
 		goto fail;

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2010-08-19 20:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-19 20:33 [S+Q Cleanup3 0/6] SLUB: Cleanups V3 Christoph Lameter
2010-08-19 20:33 ` Christoph Lameter [this message]
2010-08-19 20:33 ` [S+Q Cleanup3 2/6] slub: remove dynamic dma slab allocation Christoph Lameter
2010-08-19 20:33 ` [S+Q Cleanup3 3/6] slub: Remove static kmem_cache_cpu array for boot Christoph Lameter
2010-08-19 20:33 ` [S+Q Cleanup3 4/6] slub: Dynamically size kmalloc cache allocations Christoph Lameter
2010-08-19 21:21   ` David Rientjes
2010-08-19 21:31     ` Christoph Lameter
2010-08-19 23:01       ` David Rientjes
2010-08-19 23:20         ` Christoph Lameter
2010-08-19 23:39           ` David Rientjes
2010-08-20 17:08             ` Christoph Lameter
2010-08-20 17:32               ` Christoph Lameter
2010-09-28 10:06                 ` David Rientjes
2010-09-28 12:42                   ` Christoph Lameter
2010-08-19 20:33 ` [S+Q Cleanup3 5/6] slub: Extract hooks for memory checkers from hotpaths Christoph Lameter
2010-08-19 21:02   ` David Rientjes
2010-08-19 20:33 ` [S+Q Cleanup3 6/6] slub: Move gfpflag masking out of the hotpath Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100819203437.031478257@linux.com \
    --to=cl@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=penberg@cs.helsinki.fi \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).