From: Andrew Morton <akpm@linux-foundation.org>
To: David Rientjes <rientjes@google.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Rik van Riel <riel@redhat.com>,
linux-mm@kvack.org
Subject: Re: [patch 3/3 v3] oom: kill all threads sharing oom killed task's mm
Date: Mon, 23 Aug 2010 16:16:20 -0700 [thread overview]
Message-ID: <20100823161620.7a46f2e1.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1008201651400.16947@chino.kir.corp.google.com>
On Fri, 20 Aug 2010 16:52:38 -0700 (PDT)
David Rientjes <rientjes@google.com> wrote:
> + pr_err("Kill process %d (%s) sharing same memory\n",
> + task_pid_nr(q), q->comm);
We're really supposed to use get_task_comm() when accessing another
tasks's comm[] to avoid races with that task altering its comm[] in
prctl().
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-08-23 23:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 22:41 [patch 1/3 v3] oom: add per-mm oom disable count David Rientjes
2010-08-20 22:41 ` [patch 2/3 v3] oom: avoid killing a task if a thread sharing its mm cannot be killed David Rientjes
2010-08-22 9:49 ` KOSAKI Motohiro
2010-08-22 23:14 ` David Rientjes
2010-08-20 22:41 ` [patch 3/3 v3] oom: kill all threads sharing oom killed task's mm David Rientjes
2010-08-20 23:52 ` David Rientjes
2010-08-23 23:16 ` Andrew Morton [this message]
2010-08-24 0:57 ` David Rientjes
2010-08-23 23:13 ` [patch 1/3 v3] oom: add per-mm oom disable count Andrew Morton
2010-08-24 0:53 ` David Rientjes
2010-08-27 21:48 ` Andrew Morton
2010-08-28 22:25 ` [patch] oom: fix locking for oom_adj and oom_score_adj David Rientjes
2010-08-30 4:39 ` [patch 1/3 v3] oom: add per-mm oom disable count KOSAKI Motohiro
2010-08-30 21:14 ` David Rientjes
2010-08-31 23:54 ` KOSAKI Motohiro
2010-09-01 23:41 ` David Rientjes
2010-09-02 0:50 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100823161620.7a46f2e1.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).