From: Randy Dunlap <randy.dunlap@oracle.com>
To: Christoph Lameter <cl@linux.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-mm@kvack.org, linux-next@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: linux-next: Tree for August 25 (mm/slub)
Date: Wed, 25 Aug 2010 13:13:44 -0700 [thread overview]
Message-ID: <20100825131344.a2c26b31.randy.dunlap@oracle.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1008251447410.22117@router.home>
On Wed, 25 Aug 2010 14:51:14 -0500 (CDT) Christoph Lameter wrote:
> On Wed, 25 Aug 2010, Randy Dunlap wrote:
>
> > Certainly. config file is attached.
>
> Ah. Memory hotplug....
>
>
>
> Subject: Slub: Fix up missing kmalloc_cache -> kmem_cache_node case for memoryhotplug
>
> Memory hotplug allocates and frees per node structures. Use the correct name.
>
> Signed-off-by: Christoph Lameter <cl@linux.com>
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
Thanks.
> ---
> mm/slub.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux-2.6/mm/slub.c
> ===================================================================
> --- linux-2.6.orig/mm/slub.c 2010-08-25 14:48:23.000000000 -0500
> +++ linux-2.6/mm/slub.c 2010-08-25 14:49:03.000000000 -0500
> @@ -2909,7 +2909,7 @@ static void slab_mem_offline_callback(vo
> BUG_ON(slabs_node(s, offline_node));
>
> s->node[offline_node] = NULL;
> - kmem_cache_free(kmalloc_caches, n);
> + kmem_cache_free(kmem_cache_node, n);
> }
> }
> up_read(&slub_lock);
> @@ -2942,7 +2942,7 @@ static int slab_mem_going_online_callbac
> * since memory is not yet available from the node that
> * is brought up.
> */
> - n = kmem_cache_alloc(kmalloc_caches, GFP_KERNEL);
> + n = kmem_cache_alloc(kmem_cache_node, GFP_KERNEL);
> if (!n) {
> ret = -ENOMEM;
> goto out;
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-08-25 20:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100825132057.c8416bef.sfr@canb.auug.org.au>
2010-08-25 16:45 ` linux-next: Tree for August 25 (mm/slub) Randy Dunlap
2010-08-25 19:07 ` Christoph Lameter
2010-08-25 20:30 ` Randy Dunlap
2010-08-26 18:17 ` Pekka Enberg
2010-08-25 23:18 ` David Rientjes
2010-08-25 19:11 ` Christoph Lameter
2010-08-25 19:21 ` Randy Dunlap
2010-08-25 19:51 ` Christoph Lameter
2010-08-25 20:13 ` Randy Dunlap [this message]
2010-08-26 18:17 ` Pekka Enberg
2010-08-25 23:32 ` David Rientjes
2010-08-26 1:31 ` Christoph Lameter
2010-08-26 18:17 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100825131344.a2c26b31.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).