From: Mel Gorman <mel@csn.ul.ie>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel List <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, Wu Fengguang <fengguang.wu@intel.com>,
Iram Shahzad <iram.shahzad@jp.fujitsu.com>
Subject: Re: [PATCH v2 1/2] compaction: handle active and inactive fairly in too_many_isolated
Date: Thu, 26 Aug 2010 10:43:56 +0100 [thread overview]
Message-ID: <20100826094356.GD20944@csn.ul.ie> (raw)
In-Reply-To: <AANLkTikE-_=8GCu=LjLiyyO9W+soSKAC0bkXfYAnwMux@mail.gmail.com>
On Thu, Aug 26, 2010 at 06:39:49PM +0900, Minchan Kim wrote:
> On Thu, Aug 26, 2010 at 6:03 PM, Mel Gorman <mel@csn.ul.ie> wrote:
> > On Wed, Aug 25, 2010 at 12:31:18AM +0900, Minchan Kim wrote:
> >> Iram reported compaction's too_many_isolated loops forever.
> >> (http://www.spinics.net/lists/linux-mm/msg08123.html)
> >>
> >> The meminfo of situation happened was inactive anon is zero.
> >> That's because the system has no memory pressure until then.
> >> While all anon pages was in active lru, compaction could select
> >> active lru as well as inactive lru. That's different things
> >> with vmscan's isolated. So we has been two too_many_isolated.
> >>
> >> While compaction can isolated pages in both active and inactive,
> >> current implementation of too_many_isolated only considers inactive.
> >> It made Iram's problem.
> >>
> >> This patch handles active and inactive with fair.
> >> That's because we can't expect where from and how many compaction would
> >> isolated pages.
> >>
> >> This patch changes (nr_isolated > nr_inactive) with
> >> nr_isolated > (nr_active + nr_inactive) / 2.
> >>
> >> Cc: Iram Shahzad <iram.shahzad@jp.fujitsu.com>
> >> Acked-by: Mel Gorman <mel@csn.ul.ie>
> >> Acked-by: Wu Fengguang <fengguang.wu@intel.com>
> >> Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
> >
> > Please send this patch on its own as it looks like it should be merged and
> > arguably is a stable candidate for 2.6.35. Alternatively, Andrew, can you pick
> > up just this patch? It seems unrelated to the second patch on COMPACTPAGEFAILED.
>
> I thought it's not urgent and next patch would apply based on this
> patch without HUNK.
Well it fixes a known bug so I would consider it a little urgent. It's not
earth shattering or anything but why delay unnecessarily?
> If Andrew doesn't have a response, I will resend as a standalone.
> Thanks.
>
Thanks.
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2010-08-26 9:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-24 15:31 [PATCH v2 1/2] compaction: handle active and inactive fairly in too_many_isolated Minchan Kim
2010-08-24 15:31 ` [PATCH v2 2/2] compaction: fix COMPACTPAGEFAILED counting Minchan Kim
2010-08-24 15:42 ` Minchan Kim
2010-08-26 9:03 ` [PATCH v2 1/2] compaction: handle active and inactive fairly in too_many_isolated Mel Gorman
2010-08-26 9:39 ` Minchan Kim
2010-08-26 9:43 ` Mel Gorman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100826094356.GD20944@csn.ul.ie \
--to=mel@csn.ul.ie \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=iram.shahzad@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).