linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Wu Fengguang <fengguang.wu@gmail.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Jeff Layton <jlayton@redhat.com>,
	Christoph Hellwig <hch@infradead.org>,
	linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: why are WB_SYNC_NONE COMMITs being done with FLUSH_SYNC set ?
Date: Tue, 31 Aug 2010 07:53:06 +0800	[thread overview]
Message-ID: <20100830235306.GA5202@localhost> (raw)
In-Reply-To: <1283196174.2920.4.camel@heimdal.trondhjem.org>

On Mon, Aug 30, 2010 at 03:22:54PM -0400, Trond Myklebust wrote:
> On Fri, 2010-08-20 at 21:23 +0800, Wu Fengguang wrote:
> > > > Here's a lightly tested patch that turns the check for the two flags
> > > > into a check for WB_SYNC_NONE. It seems to do the right thing, but I
> > > > don't have a clear testcase for it. Does this look reasonable?
> > > 
> > > Looks fine to me. I'll queue it up for the post-2.6.36 merge window...
> > 
> > Trond, I just created a patch that removes the wbc->nonblocking
> > definition and all its references except NFS. So there will be merge
> > dependencies. What should we do?  To push both patches to Andrew's -mm
> > tree?
> > 
> > Thanks,
> > Fengguang
> 
> Do you want to include it as part of your series? Just remember to add
> an
> 
> Acked-by: Trond Myklebust <Trond.Myklebust@netapp.com>

Thanks. Please keep the NFS patches in your tree. I've send a patch
to Andrew Morton which removes the other references but keeps the
definitions. So that there won't be compile errors when the patches
are pushed at different time.

Thanks,
Fengguang

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2010-08-30 23:53 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20100819101525.076831ad@barsoom.rdu.redhat.com>
2010-08-19 14:37 ` why are WB_SYNC_NONE COMMITs being done with FLUSH_SYNC set ? Christoph Hellwig
2010-08-19 14:58   ` Trond Myklebust
2010-08-19 15:11     ` Jeff Layton
2010-08-19 15:24     ` Christoph Hellwig
2010-08-19 19:16     ` Jeff Layton
2010-08-19 19:43       ` Trond Myklebust
2010-08-20 13:23         ` Wu Fengguang
2010-08-30 19:22           ` Trond Myklebust
2010-08-30 23:53             ` Wu Fengguang [this message]
2010-08-20  0:33       ` Wu Fengguang
2010-08-20  0:53         ` Jeff Layton
2010-08-20 13:20           ` Wu Fengguang
2010-08-19 23:55   ` Wu Fengguang
2010-08-20  0:02     ` Wu Fengguang
2010-08-20  2:36       ` Sage Weil
2010-08-20  9:19     ` Christoph Hellwig
2010-08-20 11:27       ` Jeff Layton
2010-08-20 12:44         ` Wu Fengguang
2010-08-20 12:26       ` Wu Fengguang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100830235306.GA5202@localhost \
    --to=fengguang.wu@gmail.com \
    --cc=hch@infradead.org \
    --cc=jlayton@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).