From: Wu Fengguang <fengguang.wu@intel.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Kleen, Andi" <andi.kleen@intel.com>,
Haicheng Li <haicheng.li@linux.intel.com>,
Christoph Lameter <cl@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mel Gorman <mel@linux.vnet.ibm.com>
Subject: Re: [PATCH] Make is_mem_section_removable more conformable with offlining code
Date: Tue, 31 Aug 2010 22:36:49 +0800 [thread overview]
Message-ID: <20100831143649.GA31730@localhost> (raw)
In-Reply-To: <20100831141942.GA30353@localhost>
On Tue, Aug 31, 2010 at 10:19:42PM +0800, Wu Fengguang wrote:
> On Mon, Aug 23, 2010 at 05:22:46PM +0800, Michal Hocko wrote:
> > On Sun 22-08-10 08:42:32, Wu Fengguang wrote:
> > > Hi Michal,
> >
> > Hi,
> >
> > >
> > > It helps to explain in changelog/code
> > >
> > > - in what situation a ZONE_MOVABLE will contain !MIGRATE_MOVABLE
> > > pages?
> >
> > page can be MIGRATE_RESERVE IIUC.
>
> Yup, it may also be set to MIGRATE_ISOLATE by soft_offline_page().
Ah a non-movable page allocation could fall back into the movable
zone. See __rmqueue_fallback() and the fallbacks[][] array. So the
if (type != MIGRATE_MOVABLE && !pageblock_free(page))
check in is_mem_section_removable() is correct. It is
set_migratetype_isolate() that should be fixed to use the same check.
Thanks,
Fengguang
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-08-31 14:38 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 14:14 [PATCH] Make is_mem_section_removable more conformable with offlining code Michal Hocko
2010-08-22 0:42 ` Wu Fengguang
2010-08-23 9:22 ` Michal Hocko
2010-08-31 12:30 ` Michal Hocko
2010-08-31 14:19 ` Wu Fengguang
2010-08-31 14:36 ` Wu Fengguang [this message]
2010-08-31 14:59 ` Wu Fengguang
2010-09-01 1:19 ` KAMEZAWA Hiroyuki
2010-09-01 12:19 ` Michal Hocko
2010-09-01 12:41 ` Michal Hocko
2010-09-02 5:45 ` KAMEZAWA Hiroyuki
2010-09-02 8:28 ` Michal Hocko
2010-09-02 9:03 ` KAMEZAWA Hiroyuki
2010-09-02 9:24 ` Michal Hocko
2010-09-02 11:19 ` Hiroyuki Kamezawa
2010-09-02 13:18 ` Michal Hocko
2010-09-02 14:19 ` Hiroyuki Kamezawa
2010-09-02 14:39 ` Michal Hocko
2010-09-02 15:05 ` Michal Hocko
2010-09-03 3:10 ` [PATCH 0/2 v2] " KAMEZAWA Hiroyuki
2010-09-03 3:11 ` [PATCH 1/2][BUGFIX] fix next active pageblock calculation KAMEZAWA Hiroyuki
2010-09-03 3:14 ` [PATCH 2/2] Make is_mem_section_removable more conformable with offlining code KAMEZAWA Hiroyuki
2010-09-03 8:25 ` Michal Hocko
2010-09-03 9:13 ` KAMEZAWA Hiroyuki
2010-09-03 9:50 ` Michal Hocko
2010-09-03 10:05 ` KAMEZAWA Hiroyuki
2010-09-03 11:01 ` Michal Hocko
2010-09-03 11:42 ` [PATCH 2/2] Make is_mem_section_removable more conformable with offlining code v3 Michal Hocko
2010-09-04 2:55 ` Wu Fengguang
2010-09-06 9:16 ` Michal Hocko
2010-09-03 9:15 ` [PATCH 2/2] Make is_mem_section_removable more conformable with offlining code Michal Hocko
2010-09-03 9:24 ` KAMEZAWA Hiroyuki
2010-09-03 7:54 ` [PATCH 0/2 v2] " Michal Hocko
2010-09-03 7:57 ` [PATCH 3/2][BUGFIX] fix memory isolation notifier return value check KAMEZAWA Hiroyuki
2010-09-03 20:48 ` Andrew Morton
2010-09-03 22:05 ` Hiroyuki Kamezawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100831143649.GA31730@localhost \
--to=fengguang.wu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi.kleen@intel.com \
--cc=cl@linux-foundation.org \
--cc=haicheng.li@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@linux.vnet.ibm.com \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).