* [PATCH] avoid warning when COMPACTION is selected
@ 2010-09-03 15:38 Andrea Arcangeli
2010-09-03 20:06 ` Andrew Morton
2010-09-04 10:29 ` Mel Gorman
0 siblings, 2 replies; 4+ messages in thread
From: Andrea Arcangeli @ 2010-09-03 15:38 UTC (permalink / raw)
To: Andrew Morton; +Cc: Mel Gorman, linux-mm
From: Andrea Arcangeli <aarcange@redhat.com>
COMPACTION enables MIGRATION, but MIGRATION spawns a warning if numa
or memhotplug aren't selected. However MIGRATION doesn't depend on
them. I guess it's just trying to be strict doing a double check on
who's enabling it, but it doesn't know that compaction also enables
MIGRATION.
Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
---
diff --git a/mm/Kconfig b/mm/Kconfig
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -189,7 +189,7 @@ config COMPACTION
config MIGRATION
bool "Page migration"
def_bool y
- depends on NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE
+ depends on NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE || COMPACTION
help
Allows the migration of the physical location of pages of processes
while the virtual addresses are not changed. This is useful in
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] avoid warning when COMPACTION is selected
2010-09-03 15:38 [PATCH] avoid warning when COMPACTION is selected Andrea Arcangeli
@ 2010-09-03 20:06 ` Andrew Morton
2010-09-06 22:07 ` Andrea Arcangeli
2010-09-04 10:29 ` Mel Gorman
1 sibling, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2010-09-03 20:06 UTC (permalink / raw)
To: Andrea Arcangeli; +Cc: Mel Gorman, linux-mm
On Fri, 3 Sep 2010 17:38:26 +0200
Andrea Arcangeli <aarcange@redhat.com> wrote:
> From: Andrea Arcangeli <aarcange@redhat.com>
>
> COMPACTION enables MIGRATION, but MIGRATION spawns a warning if numa
> or memhotplug aren't selected. However MIGRATION doesn't depend on
> them. I guess it's just trying to be strict doing a double check on
> who's enabling it, but it doesn't know that compaction also enables
> MIGRATION.
>
> Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
> ---
>
> diff --git a/mm/Kconfig b/mm/Kconfig
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -189,7 +189,7 @@ config COMPACTION
> config MIGRATION
> bool "Page migration"
> def_bool y
> - depends on NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE
> + depends on NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE || COMPACTION
> help
> Allows the migration of the physical location of pages of processes
> while the virtual addresses are not changed. This is useful in
Could you please send along a copy of the warning? It's unclear
whether it's a compiler warning or a Kconfig warning or a runtime
warning or what.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] avoid warning when COMPACTION is selected
2010-09-03 20:06 ` Andrew Morton
@ 2010-09-06 22:07 ` Andrea Arcangeli
0 siblings, 0 replies; 4+ messages in thread
From: Andrea Arcangeli @ 2010-09-06 22:07 UTC (permalink / raw)
To: Andrew Morton; +Cc: Mel Gorman, linux-mm
On Fri, Sep 03, 2010 at 01:06:23PM -0700, Andrew Morton wrote:
> Could you please send along a copy of the warning? It's unclear
Sure.
> whether it's a compiler warning or a Kconfig warning or a runtime
> warning or what.
Kconfig warning.
scripts/kconfig/conf --oldconfig arch/x86/Kconfig
warning: (COMPACTION && EXPERIMENTAL && HUGETLB_PAGE && MMU) selects MIGRATION which has unmet direct dependencies (NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE)
warning: (COMPACTION && EXPERIMENTAL && HUGETLB_PAGE && MMU) selects MIGRATION which has unmet direct dependencies (NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE)
#
# configuration written to .config
#
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] avoid warning when COMPACTION is selected
2010-09-03 15:38 [PATCH] avoid warning when COMPACTION is selected Andrea Arcangeli
2010-09-03 20:06 ` Andrew Morton
@ 2010-09-04 10:29 ` Mel Gorman
1 sibling, 0 replies; 4+ messages in thread
From: Mel Gorman @ 2010-09-04 10:29 UTC (permalink / raw)
To: Andrea Arcangeli; +Cc: Andrew Morton, linux-mm
On Fri, Sep 03, 2010 at 05:38:26PM +0200, Andrea Arcangeli wrote:
> From: Andrea Arcangeli <aarcange@redhat.com>
>
> COMPACTION enables MIGRATION, but MIGRATION spawns a warning if numa
> or memhotplug aren't selected. However MIGRATION doesn't depend on
> them. I guess it's just trying to be strict doing a double check on
> who's enabling it, but it doesn't know that compaction also enables
> MIGRATION.
>
> Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
Acked-by: Mel Gorman <mel@csn.ul.ie>
This was the way an earlier version of compaction had Kconfig. I'm not sure
at what point the "|| COMPACTION" got dropped.
> ---
>
> diff --git a/mm/Kconfig b/mm/Kconfig
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -189,7 +189,7 @@ config COMPACTION
> config MIGRATION
> bool "Page migration"
> def_bool y
> - depends on NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE
> + depends on NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE || COMPACTION
> help
> Allows the migration of the physical location of pages of processes
> while the virtual addresses are not changed. This is useful in
>
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-09-06 22:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-03 15:38 [PATCH] avoid warning when COMPACTION is selected Andrea Arcangeli
2010-09-03 20:06 ` Andrew Morton
2010-09-06 22:07 ` Andrea Arcangeli
2010-09-04 10:29 ` Mel Gorman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).