From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with ESMTP id D7DDF6B0047 for ; Tue, 28 Sep 2010 17:33:13 -0400 (EDT) Date: Tue, 28 Sep 2010 14:32:39 -0700 From: Andrew Morton Subject: Re: [PATCH] mm: cleanup gfp_zone() Message-Id: <20100928143239.5fe34e1e.akpm@linux-foundation.org> In-Reply-To: <1285676624-1300-1-git-send-email-namhyung@gmail.com> References: <1285676624-1300-1-git-send-email-namhyung@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Namhyung Kim Cc: Al Viro , linux-mm@kvack.org, linux-kernel@vger.kernel.org List-ID: On Tue, 28 Sep 2010 21:23:44 +0900 Namhyung Kim wrote: > Use Z[TB]_SHIFT() macro to calculate GFP_ZONE_TABLE and GFP_ZONE_BAD. > This also removes lots of warnings from sparse like following: > > warning: restricted gfp_t degrades to integer > > Signed-off-by: Namhyung Kim > --- > include/linux/gfp.h | 43 ++++++++++++++++++++++++------------------- > 1 files changed, 24 insertions(+), 19 deletions(-) > > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > index 975609c..cebfee1 100644 > --- a/include/linux/gfp.h > +++ b/include/linux/gfp.h > @@ -185,15 +185,16 @@ static inline int allocflags_to_migratetype(gfp_t gfp_flags) > #error ZONES_SHIFT too large to create GFP_ZONE_TABLE integer > #endif > > +#define ZT_SHIFT(gfp) ((__force int) (gfp) * ZONES_SHIFT) > #define GFP_ZONE_TABLE ( \ > - (ZONE_NORMAL << 0 * ZONES_SHIFT) \ > - | (OPT_ZONE_DMA << __GFP_DMA * ZONES_SHIFT) \ > - | (OPT_ZONE_HIGHMEM << __GFP_HIGHMEM * ZONES_SHIFT) \ > - | (OPT_ZONE_DMA32 << __GFP_DMA32 * ZONES_SHIFT) \ > - | (ZONE_NORMAL << __GFP_MOVABLE * ZONES_SHIFT) \ > - | (OPT_ZONE_DMA << (__GFP_MOVABLE | __GFP_DMA) * ZONES_SHIFT) \ > - | (ZONE_MOVABLE << (__GFP_MOVABLE | __GFP_HIGHMEM) * ZONES_SHIFT)\ > - | (OPT_ZONE_DMA32 << (__GFP_MOVABLE | __GFP_DMA32) * ZONES_SHIFT)\ > + (ZONE_NORMAL << ZT_SHIFT(0)) \ > + | (OPT_ZONE_DMA << ZT_SHIFT(__GFP_DMA)) \ > + | (OPT_ZONE_HIGHMEM << ZT_SHIFT(__GFP_HIGHMEM)) \ > + | (OPT_ZONE_DMA32 << ZT_SHIFT(__GFP_DMA32)) \ > + | (ZONE_NORMAL << ZT_SHIFT(__GFP_MOVABLE)) \ > + | (OPT_ZONE_DMA << ZT_SHIFT(__GFP_MOVABLE | __GFP_DMA)) \ > + | (ZONE_MOVABLE << ZT_SHIFT(__GFP_MOVABLE | __GFP_HIGHMEM)) \ > + | (OPT_ZONE_DMA32 << ZT_SHIFT(__GFP_MOVABLE | __GFP_DMA32)) \ > ) hm. I hope these sparse warnings are sufficiently useful to justify all the gunk we're adding to support them. Is it actually finding any bugs? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org