From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
containers@lists.linux-foundation.org,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] Restrict size of page_cgroup->flags
Date: Thu, 7 Oct 2010 08:44:59 +0530 [thread overview]
Message-ID: <20101007031459.GL4195@balbir.in.ibm.com> (raw)
In-Reply-To: <20101007095458.a992969e.nishimura@mxp.nes.nec.co.jp>
* nishimura@mxp.nes.nec.co.jp <nishimura@mxp.nes.nec.co.jp> [2010-10-07 09:54:58]:
> On Wed, 6 Oct 2010 19:53:14 +0530
> Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>
> > I propose restricting page_cgroup.flags to 16 bits. The patch for the
> > same is below. Comments?
> >
> >
> > Restrict the bits usage in page_cgroup.flags
> >
> > From: Balbir Singh <balbir@linux.vnet.ibm.com>
> >
> > Restricting the flags helps control growth of the flags unbound.
> > Restriciting it to 16 bits gives us the possibility of merging
> > cgroup id with flags (atomicity permitting) and saving a whole
> > long word in page_cgroup
> >
> I agree that reducing the size of page_cgroup would be good and important.
> But, wouldn't it be better to remove ->page, if possible ?
>
Without the page pointer, how do we go from pc to page for reclaim?
--
Three Cheers,
Balbir
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-10-07 3:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 14:23 [RFC] Restrict size of page_cgroup->flags Balbir Singh
2010-10-06 23:58 ` KAMEZAWA Hiroyuki
2010-10-07 3:12 ` Balbir Singh
2010-10-07 3:18 ` KAMEZAWA Hiroyuki
2010-10-07 3:56 ` Balbir Singh
2010-10-07 4:22 ` KAMEZAWA Hiroyuki
2010-10-07 5:31 ` Balbir Singh
2010-10-07 5:39 ` KAMEZAWA Hiroyuki
2010-10-07 5:44 ` Daisuke Nishimura
2010-10-07 0:54 ` Daisuke Nishimura
2010-10-07 3:14 ` Balbir Singh [this message]
2010-10-07 3:47 ` Daisuke Nishimura
2010-10-07 4:08 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101007031459.GL4195@balbir.in.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=containers@lists.linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).