linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	linux-kernel@vger.kernel.org, fengguang.wu@intel.com,
	linux-mm@kvack.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/4] HWPOISON: Copy si_addr_lsb to user
Date: Thu, 7 Oct 2010 09:36:33 +0200	[thread overview]
Message-ID: <20101007073633.GF5010@basil.fritz.box> (raw)
In-Reply-To: <4CAD6943.2020805@jp.fujitsu.com>

On Thu, Oct 07, 2010 at 03:31:31PM +0900, Hidetoshi Seto wrote:
> (2010/10/07 5:48), Andi Kleen wrote:
> > From: Andi Kleen <ak@linux.intel.com>
> > 
> > The original hwpoison code added a new siginfo field si_addr_lsb to
> > pass the granuality of the fault address to user space. Unfortunately
> > this field was never copied to user space. Fix this here.
> > 
> > I added explicit checks for the MCEERR codes to avoid having
> > to patch all potential callers to initialize the field.
> 
> Now QEMU uses signalfd to catch the SIGBUS delivered to the
> main thread, so I think similar fix to copy lsb to user is
> required for signalfd too. 

Good catch. I don't think qemu uses this today, but it should
be fixed there too for .37 at least.

-Andi

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2010-10-07  7:36 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-06 20:48 HWPoison fixes for 2.6.36 Andi Kleen
2010-10-06 20:48 ` [PATCH 1/4] page-types.c: fix name of unpoison interface Andi Kleen
2010-10-06 20:48 ` [PATCH 2/4] HWPOISON: Copy si_addr_lsb to user Andi Kleen
2010-10-07  0:27   ` Naoya Horiguchi
2010-10-07  6:31   ` Hidetoshi Seto
2010-10-07  7:36     ` Andi Kleen [this message]
2010-10-08 17:09   ` Ralf Baechle
2010-10-08 17:32     ` Andi Kleen
2010-10-06 20:49 ` [PATCH 3/4] HWPOISON: Report correct address granuality for AO huge page errors Andi Kleen
2010-10-07  0:31   ` Naoya Horiguchi
2010-10-07  7:38     ` Andi Kleen
2010-10-07  8:41       ` Naoya Horiguchi
2010-10-07  8:45         ` Andi Kleen
2010-10-07  8:48           ` Naoya Horiguchi
2010-10-07  8:58             ` Andi Kleen
2010-10-07  1:50   ` Wu Fengguang
2010-10-06 20:49 ` [PATCH 4/4] HWPOISON: Stop shrinking at right page count Andi Kleen
2010-10-07  1:53   ` Wu Fengguang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101007073633.GF5010@basil.fritz.box \
    --to=andi@firstfloor.org \
    --cc=ak@linux.intel.com \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=seto.hidetoshi@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).