From: Gleb Natapov <gleb@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, avi@redhat.com, mingo@elte.hu,
a.p.zijlstra@chello.nl, tglx@linutronix.de, hpa@zytor.com,
riel@redhat.com, cl@linux-foundation.org
Subject: Re: [PATCH v6 03/12] Retry fault before vmentry
Date: Thu, 7 Oct 2010 20:44:57 +0200 [thread overview]
Message-ID: <20101007184457.GA8354@redhat.com> (raw)
In-Reply-To: <20101006142050.GA31423@amt.cnet>
On Wed, Oct 06, 2010 at 11:20:50AM -0300, Marcelo Tosatti wrote:
> On Wed, Oct 06, 2010 at 01:07:04PM +0200, Gleb Natapov wrote:
> > > Can't you set a bit in vcpu->requests instead, and handle it in "out:"
> > > at the end of vcpu_enter_guest?
> > >
> > > To have a single entry point for pagefaults, after vmexit handling.
> > Jumping to "out:" will skip vmexit handling anyway, so we will not reuse
> > same call site anyway. I don't see yet why the way you propose will have
> > an advantage.
>
> What i meant was to call pagefault handler after vmexit handling.
>
> Because the way it is in your patch now, with pre pagefault on entry,
> one has to make an effort to verify ordering wrt other events on entry
> processing.
>
What events do you have in mind?
> With pre pagefault after vmexit, its more natural.
>
I do not see non-ugly way to pass information that is needed to perform
the prefault to the place you want me to put it. We can skip guest entry
in case prefault was done which will have the same effect as your
proposal, but I want to have a good reason to do so since otherwise we
will just do more work for nothing on guest entry.
> Does that make sense?
--
Gleb.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-10-07 18:45 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-04 15:56 [PATCH v6 00/12] KVM: Add host swap event notifications for PV guest Gleb Natapov
2010-10-04 15:56 ` [PATCH v6 01/12] Add get_user_pages() variant that fails if major fault is required Gleb Natapov
2010-10-04 15:56 ` [PATCH v6 02/12] Halt vcpu if page it tries to access is swapped out Gleb Natapov
2010-10-05 1:20 ` Rik van Riel
2010-10-05 14:59 ` Marcelo Tosatti
2010-10-06 10:50 ` Avi Kivity
2010-10-06 10:52 ` Gleb Natapov
2010-10-07 9:54 ` Avi Kivity
2010-10-07 17:48 ` Gleb Natapov
2010-10-06 11:15 ` Gleb Natapov
2010-10-07 9:50 ` Avi Kivity
2010-10-07 9:52 ` Avi Kivity
2010-10-07 13:24 ` Rik van Riel
2010-10-07 13:29 ` Avi Kivity
2010-10-07 17:47 ` Gleb Natapov
2010-10-09 18:30 ` Avi Kivity
2010-10-09 18:32 ` Avi Kivity
2010-10-10 7:30 ` Gleb Natapov
2010-10-10 7:29 ` Gleb Natapov
2010-10-10 15:55 ` Avi Kivity
2010-10-10 15:56 ` Avi Kivity
2010-10-10 16:17 ` Gleb Natapov
2010-10-10 16:16 ` Gleb Natapov
2010-10-04 15:56 ` [PATCH v6 03/12] Retry fault before vmentry Gleb Natapov
2010-10-05 15:54 ` Marcelo Tosatti
2010-10-06 11:07 ` Gleb Natapov
2010-10-06 14:20 ` Marcelo Tosatti
2010-10-07 18:44 ` Gleb Natapov [this message]
2010-10-08 16:07 ` Marcelo Tosatti
2010-10-07 12:29 ` Avi Kivity
2010-10-07 17:21 ` Gleb Natapov
2010-10-09 18:42 ` Avi Kivity
2010-10-10 7:35 ` Gleb Natapov
2010-10-04 15:56 ` [PATCH v6 04/12] Add memory slot versioning and use it to provide fast guest write interface Gleb Natapov
2010-10-05 1:29 ` Rik van Riel
2010-10-05 16:57 ` Marcelo Tosatti
2010-10-06 11:14 ` Gleb Natapov
2010-10-06 14:38 ` Marcelo Tosatti
2010-10-06 20:08 ` Gleb Natapov
2010-10-07 10:00 ` Avi Kivity
2010-10-07 15:42 ` Marcelo Tosatti
2010-10-07 16:03 ` Gleb Natapov
2010-10-07 16:20 ` Avi Kivity
2010-10-07 17:23 ` Gleb Natapov
2010-10-10 12:48 ` Avi Kivity
2010-10-07 12:31 ` Avi Kivity
2010-10-04 15:56 ` [PATCH v6 05/12] Move kvm_smp_prepare_boot_cpu() from kvmclock.c to kvm.c Gleb Natapov
2010-10-04 15:56 ` [PATCH v6 06/12] Add PV MSR to enable asynchronous page faults delivery Gleb Natapov
2010-10-07 12:42 ` Avi Kivity
2010-10-07 17:53 ` Gleb Natapov
2010-10-10 12:47 ` Avi Kivity
2010-10-10 13:27 ` Gleb Natapov
2010-10-07 12:58 ` Avi Kivity
2010-10-07 17:59 ` Gleb Natapov
2010-10-09 18:43 ` Avi Kivity
2010-10-04 15:56 ` [PATCH v6 07/12] Add async PF initialization to PV guest Gleb Natapov
2010-10-05 2:34 ` Rik van Riel
2010-10-05 18:25 ` Marcelo Tosatti
2010-10-06 10:55 ` Gleb Natapov
2010-10-06 14:45 ` Marcelo Tosatti
2010-10-06 20:05 ` Gleb Natapov
2010-10-07 12:50 ` Avi Kivity
2010-10-08 7:54 ` Gleb Natapov
2010-10-09 18:44 ` Avi Kivity
2010-10-04 15:56 ` [PATCH v6 08/12] Handle async PF in a guest Gleb Natapov
2010-10-07 13:10 ` Avi Kivity
2010-10-07 17:14 ` Gleb Natapov
2010-10-07 17:18 ` Avi Kivity
2010-10-07 17:48 ` Rik van Riel
2010-10-07 18:03 ` Gleb Natapov
2010-10-09 18:48 ` Avi Kivity
2010-10-10 7:56 ` Gleb Natapov
2010-10-10 12:40 ` Avi Kivity
2010-10-10 12:32 ` Gleb Natapov
2010-10-10 12:38 ` Avi Kivity
2010-10-10 13:22 ` Gleb Natapov
2010-10-04 15:56 ` [PATCH v6 09/12] Inject asynchronous page fault into a PV guest if page is swapped out Gleb Natapov
2010-10-05 2:36 ` Rik van Riel
2010-10-05 19:00 ` Marcelo Tosatti
2010-10-06 10:42 ` Gleb Natapov
2010-10-04 15:56 ` [PATCH v6 10/12] Handle async PF in non preemptable context Gleb Natapov
2010-10-05 19:51 ` Marcelo Tosatti
2010-10-06 10:41 ` Gleb Natapov
2010-10-10 14:25 ` Gleb Natapov
2010-10-04 15:56 ` [PATCH v6 11/12] Let host know whether the guest can handle async PF in non-userspace context Gleb Natapov
2010-10-07 13:36 ` Avi Kivity
2010-10-04 15:56 ` [PATCH v6 12/12] Send async PF when guest is not in userspace too Gleb Natapov
2010-10-05 2:37 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101007184457.GA8354@redhat.com \
--to=gleb@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=avi@redhat.com \
--cc=cl@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=mtosatti@redhat.com \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).