From: Ralf Baechle <ralf@linux-mips.org>
To: Andi Kleen <andi@firstfloor.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, fengguang.wu@intel.com,
linux-mm@kvack.org, Andi Kleen <ak@linux.intel.com>,
Manuel Lauss <manuel.lauss@googlemail.com>,
linux-mips@linux-mips.org
Subject: Re: [PATCH 2/4] HWPOISON: Copy si_addr_lsb to user
Date: Fri, 8 Oct 2010 18:09:41 +0100 [thread overview]
Message-ID: <20101008170941.GA3025@linux-mips.org> (raw)
In-Reply-To: <1286398141-13749-3-git-send-email-andi@firstfloor.org>
On Wed, Oct 06, 2010 at 10:48:59PM +0200, Andi Kleen wrote:
> The original hwpoison code added a new siginfo field si_addr_lsb to
> pass the granuality of the fault address to user space. Unfortunately
> this field was never copied to user space. Fix this here.
>
> I added explicit checks for the MCEERR codes to avoid having
> to patch all potential callers to initialize the field.
That doesn't fly, see below.
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -2215,6 +2215,14 @@ int copy_siginfo_to_user(siginfo_t __user *to, siginfo_t *from)
> #ifdef __ARCH_SI_TRAPNO
> err |= __put_user(from->si_trapno, &to->si_trapno);
> #endif
> +#ifdef BUS_MCEERR_AO
> + /*
> + * Other callers might not initialize the si_lsb field,
> + * so check explicitely for the right codes here.
> + */
> + if (from->si_code == BUS_MCEERR_AR || from->si_code == BUS_MCEERR_AO)
> + err |= __put_user(from->si_addr_lsb, &to->si_addr_lsb);
> +#endif
include/asm-generic/siginfo.h defines BUS_MCEERR_AR unconditionally and is
getting include in all <asm/siginfo.h> so that #ifdef condition is always
true. struct siginfo.si_addr_lsb is defined only for the generic struct
siginfo. The architectures that define HAVE_ARCH_SIGINFO_T (MIPS and
IA-64) do not define this field so the build breaks.
Ralf
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-10-08 17:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 20:48 HWPoison fixes for 2.6.36 Andi Kleen
2010-10-06 20:48 ` [PATCH 1/4] page-types.c: fix name of unpoison interface Andi Kleen
2010-10-06 20:48 ` [PATCH 2/4] HWPOISON: Copy si_addr_lsb to user Andi Kleen
2010-10-07 0:27 ` Naoya Horiguchi
2010-10-07 6:31 ` Hidetoshi Seto
2010-10-07 7:36 ` Andi Kleen
2010-10-08 17:09 ` Ralf Baechle [this message]
2010-10-08 17:32 ` Andi Kleen
2010-10-06 20:49 ` [PATCH 3/4] HWPOISON: Report correct address granuality for AO huge page errors Andi Kleen
2010-10-07 0:31 ` Naoya Horiguchi
2010-10-07 7:38 ` Andi Kleen
2010-10-07 8:41 ` Naoya Horiguchi
2010-10-07 8:45 ` Andi Kleen
2010-10-07 8:48 ` Naoya Horiguchi
2010-10-07 8:58 ` Andi Kleen
2010-10-07 1:50 ` Wu Fengguang
2010-10-06 20:49 ` [PATCH 4/4] HWPOISON: Stop shrinking at right page count Andi Kleen
2010-10-07 1:53 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101008170941.GA3025@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mm@kvack.org \
--cc=manuel.lauss@googlemail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).