From: Wu Fengguang <fengguang.wu@intel.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] HWPOISON: Implement hwpoison-on-free for soft offlining
Date: Tue, 12 Oct 2010 20:41:35 +0800 [thread overview]
Message-ID: <20101012124135.GA15163@localhost> (raw)
In-Reply-To: <4CB45672.7020206@linux.intel.com>
> >> + if (PageHWPoisonOnFree(page))
> >> + hwpoison_page_on_free(page);
> > hwpoison_page_on_free() seems to be undefined when
> > CONFIG_HWPOISON_ON_FREE is not defined.
>
> Yes, but I rely on the compiler never generating the call in this case
> because
> the test is zero.
>
> It would fail on a unoptimized build, but the kernel doesn't support
> that anyways.
Fair enough.
Reviewed-by: Wu Fengguang <fengguang.wu@intel.com>
> Thanks for the review.
:)
Thanks,
Fengguang
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-10-12 12:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 22:09 RFC: Implement hwpoison on free for soft offlining Andi Kleen
2010-10-06 22:09 ` [PATCH] HWPOISON: Implement hwpoison-on-free " Andi Kleen
2010-10-12 12:26 ` Wu Fengguang
2010-10-12 12:37 ` Andi Kleen
2010-10-12 12:41 ` Wu Fengguang [this message]
2010-10-12 8:11 ` RFC: Implement hwpoison on free " Andi Kleen
2010-10-12 9:20 ` KOSAKI Motohiro
2010-10-12 13:14 ` Andi Kleen
2010-10-13 0:15 ` KOSAKI Motohiro
2010-10-15 8:50 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101012124135.GA15163@localhost \
--to=fengguang.wu@intel.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).