From: Wu Fengguang <fengguang.wu@intel.com>
To: Bob Liu <lliubbo@gmail.com>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"kamezawa.hiroyu@jp.fujitsu.com" <kamezawa.hiroyu@jp.fujitsu.com>,
"mel@csn.ul.ie" <mel@csn.ul.ie>,
"kosaki.motohiro@jp.fujitsu.com" <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [PATCH 2/3] do_migrate_range: exit loop if not_managed is true.
Date: Thu, 21 Oct 2010 22:25:34 +0800 [thread overview]
Message-ID: <20101021142534.GB9709@localhost> (raw)
In-Reply-To: <1287667701-8081-2-git-send-email-lliubbo@gmail.com>
On Thu, Oct 21, 2010 at 09:28:20PM +0800, Bob Liu wrote:
> If not_managed is true all pages will be putback to lru, so
> break the loop earlier to skip other pages isolate.
It's good fix in itself. However it's normal for isolate_lru_page() to
fail at times (when there are active reclaimers). The failures are
typically temporal and may well go away when offline_pages() retries
the call. So it seems more reasonable to migrate as much as possible
to increase the chance of complete success in next retry.
> Signed-off-by: Bob Liu <lliubbo@gmail.com>
> ---
> mm/memory_hotplug.c | 10 ++++++----
> 1 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index d4e940a..4f72184 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -709,15 +709,17 @@ do_migrate_range(unsigned long start_pfn, unsigned long end_pfn)
> page_is_file_cache(page));
>
> } else {
> - /* Becasue we don't have big zone->lock. we should
> - check this again here. */
> - if (page_count(page))
> - not_managed++;
> #ifdef CONFIG_DEBUG_VM
> printk(KERN_ALERT "removing pfn %lx from LRU failed\n",
> pfn);
> dump_page(page);
> #endif
> + /* Becasue we don't have big zone->lock. we should
> + check this again here. */
> + if (page_count(page)) {
> + not_managed++;
> + break;
> + }
> }
> }
> ret = -EBUSY;
> --
> 1.5.6.3
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-10-21 14:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 13:28 [PATCH 1/3] page_isolation: codeclean fix comment and rm unneeded val init Bob Liu
2010-10-21 13:28 ` [PATCH 2/3] do_migrate_range: exit loop if not_managed is true Bob Liu
2010-10-21 13:28 ` [PATCH 3/3] do_migrate_range: reduce list_empty() check Bob Liu
2010-10-22 3:17 ` KAMEZAWA Hiroyuki
2010-10-25 6:02 ` Wu Fengguang
2010-10-25 21:36 ` Andrew Morton
2010-10-21 14:25 ` Wu Fengguang [this message]
2010-10-22 2:48 ` [PATCH 2/3] do_migrate_range: exit loop if not_managed is true Bob Liu
2010-10-22 3:22 ` Wu Fengguang
2010-10-22 8:41 ` Bob Liu
2010-10-22 10:23 ` Wu Fengguang
2010-10-22 3:16 ` KAMEZAWA Hiroyuki
2010-10-22 8:41 ` Bob Liu
2010-10-22 8:43 ` KAMEZAWA Hiroyuki
2010-10-25 5:51 ` Wu Fengguang
2010-10-21 14:01 ` [PATCH 1/3] page_isolation: codeclean fix comment and rm unneeded val init Wu Fengguang
2010-10-22 2:34 ` Bob Liu
2010-10-22 3:13 ` Wu Fengguang
2010-10-22 3:12 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101021142534.GB9709@localhost \
--to=fengguang.wu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=lliubbo@gmail.com \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).