From: Nick Piggin <npiggin@kernel.dk>
To: Christoph Lameter <cl@linux.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
akpm@linux-foundation.org, npiggin@kernel.dk,
Pekka Enberg <penberg@cs.helsinki.fi>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, Andi Kleen <andi@firstfloor.org>
Subject: Re: vmscan: Do not run shrinkers for zones other than ZONE_NORMAL
Date: Sun, 24 Oct 2010 12:37:32 +1100 [thread overview]
Message-ID: <20101024013732.GC3168@amd> (raw)
In-Reply-To: <alpine.DEB.2.00.1010220859080.19498@router.home>
On Fri, Oct 22, 2010 at 09:06:48AM -0500, Christoph Lameter wrote:
> On Fri, 22 Oct 2010, KOSAKI Motohiro wrote:
>
> > I think this series has the same target with Nick's per-zone shrinker.
> > So, Do you dislike Nick's approach? can you please elaborate your intention?
>
> Sorry. I have not seen Nicks approach.
Latest was posted to linux-mm a few days ago.
> The per zone approach seems to be at variance with how objects are tracked
> at the slab layer. There is no per zone accounting there. So attempts to
> do expiration of caches etc at that layer would not work right.
It is not a "slab shrinker", despite the convention to call it that.
It is a "did you allocate memory that you might be nice and be able
to give some back if we have a memory shortage" callback.
The pagecache is all totally driven (calculated, accounted, scanned)
per-zone, and pagecache reclaim progress drives shrinker reclaim.
Making it per-node adds an unneccesary complicated coupling.
If a particular subsystem only tracks things on a per-node basis, they
can easily to zone_to_nid(zone) in the callback or something like that.
But really, doing LRUs in the zones makes much more sense than in the
nodes. Slab layer doesn't have huge amounts of critical reclaimable
objects like dcache or inode layers, so it is probably fine just to
kick off slab reapers for the node when it gets a request.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-10-24 1:37 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 17:59 vmscan: Do not run shrinkers for zones other than ZONE_NORMAL Christoph Lameter
2010-10-21 18:00 ` shrinkers: Add node to indicate where to target shrinking Christoph Lameter
2010-10-21 18:12 ` Andi Kleen
2010-10-21 20:57 ` David Rientjes
2010-10-21 21:07 ` Christoph Lameter
2010-10-22 13:27 ` Andi Kleen
2010-10-21 23:58 ` Nick Piggin
2010-10-22 12:12 ` Andi Kleen
2010-10-22 15:55 ` Christoph Hellwig
2010-10-22 16:32 ` Christoph Lameter
2010-10-24 1:42 ` Nick Piggin
2010-10-25 0:57 ` KOSAKI Motohiro
2010-10-25 14:59 ` Christoph Lameter
2010-11-09 4:03 ` Nick Piggin
2010-10-22 16:46 ` Andi Kleen
2010-10-24 1:31 ` Nick Piggin
2010-11-14 2:26 ` Michel Lespinasse
2010-11-14 7:10 ` KOSAKI Motohiro
2010-11-14 11:05 ` Michel Lespinasse
2010-11-15 0:29 ` KOSAKI Motohiro
2010-10-21 18:13 ` vmscan: Do not run shrinkers for zones other than ZONE_NORMAL Andi Kleen
2010-10-21 18:22 ` Christoph Lameter
2010-10-21 18:27 ` Christoph Lameter
2010-10-21 18:33 ` Andi Kleen
2010-10-21 20:48 ` David Rientjes
2010-10-21 20:54 ` Christoph Lameter
2010-10-21 19:40 ` Andrew Morton
2010-10-21 20:03 ` Christoph Lameter
2010-10-21 20:14 ` Andrew Morton
2010-10-21 20:28 ` Christoph Lameter
2010-10-21 20:36 ` Andrew Morton
2010-10-21 20:49 ` Christoph Lameter
2010-10-21 20:59 ` Andrew Morton
2010-10-21 21:13 ` Christoph Lameter
2010-10-21 21:21 ` Andrew Morton
2010-10-21 23:04 ` Christoph Lameter
2010-10-21 23:56 ` Nick Piggin
2010-10-22 1:37 ` KOSAKI Motohiro
2010-10-22 14:06 ` Christoph Lameter
2010-10-24 1:37 ` Nick Piggin [this message]
2010-10-25 1:22 ` KOSAKI Motohiro
2010-10-25 15:07 ` Christoph Lameter
2010-10-26 2:52 ` KOSAKI Motohiro
2010-10-26 12:42 ` KOSAKI Motohiro
2010-10-26 13:10 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101024013732.GC3168@amd \
--to=npiggin@kernel.dk \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=cl@linux.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).