From: Mel Gorman <mel@csn.ul.ie>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.cz>,
fengguang.wu@intel.com
Subject: Re: [BUGFIX][PATCH] fix is_mem_section_removable() page_order BUG_ON check.
Date: Mon, 25 Oct 2010 18:03:21 +0100 [thread overview]
Message-ID: <20101025170321.GA5383@csn.ul.ie> (raw)
In-Reply-To: <20101025153726.2ae9baec.kamezawa.hiroyu@jp.fujitsu.com>
On Mon, Oct 25, 2010 at 03:37:26PM +0900, KAMEZAWA Hiroyuki wrote:
> I wonder this should be for stable tree...but want to hear opinions before.
Because it's VM_BUG_ON instead of BUG_ON, I don't think it's something
we are likely to see triggered on stable kernels. It is worth
introducing a VM_WARN_ON do you think to catch really bad callers, ones
where it is not advisory?
Whether such a helper was introduced or not though, this does fix a real
problem so;
Acked-by: Mel Gorman <mel@csn.ul.ie>
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2010-10-25 17:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-25 6:37 [BUGFIX][PATCH] fix is_mem_section_removable() page_order BUG_ON check KAMEZAWA Hiroyuki
2010-10-25 7:49 ` Wu Fengguang
2010-10-25 13:10 ` Michal Hocko
2010-10-25 13:16 ` Wu Fengguang
2010-10-25 21:24 ` Andrew Morton
2010-10-25 17:03 ` Mel Gorman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101025170321.GA5383@csn.ul.ie \
--to=mel@csn.ul.ie \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).