From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with SMTP id 8E3ED8D0001 for ; Wed, 3 Nov 2010 10:15:34 -0400 (EDT) Date: Wed, 3 Nov 2010 22:15:29 +0800 From: Wu Fengguang Subject: Re: [PATCH] cgroup: prefer [kv]zalloc over [kv]malloc+memset in memory controller code. Message-ID: <20101103141529.GA7713@localhost> References: <20101101200122.GH840@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org To: Jesper Juhl Cc: Johannes Weiner , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Balbir Singh , Pavel Emelianov , Minchan Kim , Paul Menage , Li Zefan , containers@lists.linux-foundation.org List-ID: On Mon, Nov 01, 2010 at 08:59:13PM +0100, Jesper Juhl wrote: > @@ -4169,13 +4169,11 @@ static int alloc_mem_cgroup_per_zone_info(struct mem_cgroup *mem, int node) > */ > if (!node_state(node, N_NORMAL_MEMORY)) > tmp = -1; > - pn = kmalloc_node(sizeof(*pn), GFP_KERNEL, tmp); > + pn = kmalloc_node(sizeof(*pn), GFP_KERNEL|__GFP_ZERO, tmp); Use the simpler kzalloc_node()? It's introduced here: commit 979b0fea2d9ae5d57237a368d571cbc84655fba6 Author: Jeff Layton Date: Thu Jun 5 22:47:00 2008 -0700 vm: add kzalloc_node() inline Reviewed-by: Wu Fengguang Thanks, Fengguang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org