From: Andrew Morton <akpm@linux-foundation.org>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
arunabal@in.ibm.com, sbest@us.ibm.com, stable <stable@kernel.org>,
Christoph Hellwig <hch@lst.de>, Al Viro <viro@zeniv.linux.org.uk>,
Rik van Riel <riel@redhat.com>,
Minchan Kim <minchan.kim@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [v2][PATCH] [v2] Revalidate page->mapping in do_generic_file_read()
Date: Mon, 8 Nov 2010 16:05:55 -0800 [thread overview]
Message-ID: <20101108160555.2925ea57.akpm@linux-foundation.org> (raw)
In-Reply-To: <20101105211615.2D67A348@kernel.beaverton.ibm.com>
On Fri, 05 Nov 2010 14:16:15 -0700
Dave Hansen <dave@linux.vnet.ibm.com> wrote:
> --- linux-2.6.git/mm/filemap.c~is_partially_uptodate-revalidate-page 2010-11-03 13:49:21.000000000 -0700
> +++ linux-2.6.git-dave/mm/filemap.c 2010-11-04 06:59:08.000000000 -0700
> @@ -1016,6 +1016,9 @@ find_page:
> goto page_not_up_to_date;
> if (!trylock_page(page))
> goto page_not_up_to_date;
> + /* Did it get truncated before we got the lock? */
> + if (!page->mapping)
> + goto page_not_up_to_date_locked;
> if (!mapping->a_ops->is_partially_uptodate(page,
> desc, offset))
> goto page_not_up_to_date_locked;
whoops.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2010-11-09 0:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-05 21:16 [v2][PATCH] [v2] Revalidate page->mapping in do_generic_file_read() Dave Hansen
2010-11-09 0:05 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101108160555.2925ea57.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=arunabal@in.ibm.com \
--cc=dave@linux.vnet.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
--cc=sbest@us.ibm.com \
--cc=stable@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).