From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with SMTP id 7D3BB6B009D for ; Mon, 8 Nov 2010 18:19:45 -0500 (EST) Message-Id: <20101108231727.275529265@intel.com> Date: Tue, 09 Nov 2010 07:09:21 +0800 From: Wu Fengguang Subject: [PATCH 5/5] writeback: check skipped pages on WB_SYNC_ALL References: <20101108230916.826791396@intel.com> Content-Disposition: inline; filename=writeback-warn-sync-skipped_pages.patch Sender: owner-linux-mm@kvack.org To: Andrew Morton Cc: Jan Kara , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Johannes Weiner , Wu Fengguang , Christoph Hellwig , Jan Engelhardt , LKML List-ID: In WB_SYNC_ALL mode, filesystems are not expected to skip dirty pages on temporal lock contentions or non fatal errors, otherwise sync() will return without actually syncing the skipped pages. Add a check to catch possible redirty_page_for_writepage() callers that violate this expectation. I'd recommend to keep this check in -mm tree for some time and fixup the possible warnings before pushing it to upstream. Signed-off-by: Wu Fengguang --- fs/fs-writeback.c | 1 + 1 file changed, 1 insertion(+) --- linux-next.orig/fs/fs-writeback.c 2010-11-07 22:01:06.000000000 +0800 +++ linux-next/fs/fs-writeback.c 2010-11-07 22:01:15.000000000 +0800 @@ -527,6 +527,7 @@ static int writeback_sb_inodes(struct su * buffers. Skip this inode for now. */ redirty_tail(inode); + WARN_ON_ONCE(wbc->sync_mode == WB_SYNC_ALL); } spin_unlock(&inode_lock); iput(inode); -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org