From: Nick Piggin <npiggin@kernel.dk>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: Nick Piggin <npiggin@kernel.dk>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Subject: Re: [patch] mm: find_get_pages_contig fixlet
Date: Fri, 12 Nov 2010 16:48:00 +1100 [thread overview]
Message-ID: <20101112054800.GA3332@amd> (raw)
In-Reply-To: <20101111120255.GA7654@localhost>
On Thu, Nov 11, 2010 at 08:02:55PM +0800, Wu Fengguang wrote:
> On Thu, Nov 11, 2010 at 06:54:55PM +1100, Nick Piggin wrote:
> > Testing ->mapping and ->index without a ref is not stable as the page
> > may have been reused at this point.
> >
> > Signed-off-by: Nick Piggin <npiggin@kernel.dk>
>
> Reviewed-by: Wu Fengguang <fengguang.wu@intel.com>
>
> Just out of curious, did you catch it by code review or tests?
It was just review.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-11-12 5:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 7:54 [patch] mm: find_get_pages_contig fixlet Nick Piggin
2010-11-11 12:02 ` Wu Fengguang
2010-11-12 5:48 ` Nick Piggin [this message]
2010-11-12 5:58 ` Minchan Kim
2010-11-12 6:05 ` Andrew Morton
2010-11-12 7:25 ` Minchan Kim
2010-11-15 4:36 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101112054800.GA3332@amd \
--to=npiggin@kernel.dk \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).