From: Ted Ts'o <tytso@mit.edu>
To: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: Hugh Dickins <hughd@google.com>, Christoph Lameter <cl@linux.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4 Fix setting random pages PageUptodate
Date: Tue, 16 Nov 2010 15:38:54 -0500 [thread overview]
Message-ID: <20101116203854.GA1568@thunk.org> (raw)
In-Reply-To: <20101116111339.GA1544@arch.trippelsdorf.de>
On Tue, Nov 16, 2010 at 12:13:39PM +0100, Markus Trippelsdorf wrote:
> ext4_end_bio calls put_page and kmem_cache_free before calling
> SetPageUpdate(). This can result in setting the PageUptodate bit on
> random pages and causes the following BUG:
Oops. Thanks muchly to you and to Hugh for discovering this.
I've added this to the ext4 patch queue and will be pushing to Linus
this week, for -rc3.
- Ted
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2010-11-16 20:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 15:25 BUG: Bad page state in process (current git) Markus Trippelsdorf
2010-11-10 15:40 ` Markus Trippelsdorf
2010-11-10 21:46 ` Christoph Lameter
2010-11-12 12:20 ` Markus Trippelsdorf
2010-11-15 12:38 ` Markus Trippelsdorf
2010-11-15 19:54 ` Markus Trippelsdorf
2010-11-15 21:23 ` Hugh Dickins
2010-11-16 11:13 ` [PATCH] ext4 Fix setting random pages PageUptodate Markus Trippelsdorf
2010-11-16 20:38 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101116203854.GA1568@thunk.org \
--to=tytso@mit.edu \
--cc=cl@linux.com \
--cc=hughd@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=markus@trippelsdorf.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).