From: Andrew Morton <akpm@linux-foundation.org>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Rik van Riel <riel@redhat.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Nick Piggin <npiggin@kernel.dk>
Subject: Re: [RFC 1/2] deactive invalidated pages
Date: Mon, 22 Nov 2010 21:01:32 -0800 [thread overview]
Message-ID: <20101122210132.be9962c7.akpm@linux-foundation.org> (raw)
In-Reply-To: <AANLkTimk4JL7hDvLWuHjiXGNYxz8GJ_TypWFC=74Xt1Q@mail.gmail.com>
On Tue, 23 Nov 2010 13:52:05 +0900 Minchan Kim <minchan.kim@gmail.com> wrote:
> >> +/*
> >> + * Function used to forecefully demote a page to the head of the inactive
> >> + * list.
> >> + */
> >
> > This comment is wrong? __The page gets moved to the _tail_ of the
> > inactive list?
>
> No. I add it in _head_ of the inactive list intentionally.
> Why I don't add it to _tail_ is that I don't want to be aggressive.
> The page might be real working set. So I want to give a chance to
> activate it again.
Well.. why? The user just tried to toss the page away altogether. If
the kernel wasn't able to do that immediately, the best it can do is to
toss the page away asap?
> If it's not working set, it can be reclaimed easily and it can prevent
> active page demotion since inactive list size would be big enough for
> not calling shrink_active_list.
What is "working set"? Mapped and unmapped pagecache, or are you
referring solely to mapped pagecache?
If it's mapped pagecache then the user was being a bit silly (or didn't
know that some other process had mapped the file). In which case we
need to decide what to do - leave the page alone, deactivate it, or
half-deactivate it as this patch does.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-11-23 5:05 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-21 14:30 [RFC 1/2] deactive invalidated pages Minchan Kim
2010-11-21 14:30 ` [RFC 2/2] Prevent promotion of page in madvise_dontneed Minchan Kim
2010-11-21 14:38 ` Minchan Kim
2010-11-21 16:34 ` Ben Gamari
2010-11-22 0:31 ` Minchan Kim
2010-11-22 22:21 ` Andrew Morton
2010-11-23 4:57 ` Minchan Kim
2010-11-23 9:50 ` Mel Gorman
2010-11-23 23:49 ` Minchan Kim
2010-11-21 15:21 ` [RFC 1/2] deactive invalidated pages Ben Gamari
2010-11-23 7:16 ` KOSAKI Motohiro
2010-11-23 13:48 ` Ben Gamari
2010-11-23 23:48 ` Minchan Kim
2010-11-23 14:49 ` [RFC PATCH] fadvise support in rsync Ben Gamari
2010-11-23 15:35 ` Pádraig Brady
2010-11-24 0:17 ` KOSAKI Motohiro
2010-11-23 14:49 ` [PATCH 1/3] Add fadvise interface wrapper Ben Gamari
2010-11-23 14:49 ` [PATCH 2/3] Inform kernel of FADV_DONTNEED hint in sender Ben Gamari
2010-11-23 14:49 ` [PATCH 3/3] Inform kernel of FADV_DONTNEED hint in receiver Ben Gamari
2010-11-22 1:17 ` [RFC 1/2] deactive invalidated pages Rik van Riel
2010-11-22 22:14 ` Andrew Morton
2010-11-23 4:52 ` Minchan Kim
2010-11-23 5:01 ` Andrew Morton [this message]
2010-11-23 5:23 ` Minchan Kim
2010-11-23 5:22 ` Andrew Morton
2010-11-23 5:45 ` Minchan Kim
2010-11-23 5:48 ` Andrew Morton
2010-11-23 6:05 ` Minchan Kim
2010-11-23 7:15 ` Andrew Morton
2010-11-23 7:44 ` Minchan Kim
2010-11-23 7:53 ` Andrew Morton
2010-11-23 8:02 ` Minchan Kim
2010-11-23 9:43 ` Mel Gorman
2010-11-23 23:32 ` Minchan Kim
2010-11-23 9:38 ` Mel Gorman
2010-11-23 14:55 ` Ben Gamari
2010-11-23 14:58 ` Mel Gorman
2010-11-23 20:35 ` Andrew Morton
2010-11-23 22:10 ` Mel Gorman
2010-11-23 23:45 ` Minchan Kim
2010-11-24 18:01 ` Mel Gorman
2010-11-23 7:16 ` KOSAKI Motohiro
2010-11-23 7:40 ` Minchan Kim
2010-11-23 7:42 ` Andrew Morton
2010-11-23 8:01 ` KOSAKI Motohiro
2010-11-23 8:44 ` Minchan Kim
2010-11-23 9:02 ` KOSAKI Motohiro
2010-11-23 9:05 ` Minchan Kim
2010-11-23 9:07 ` Minchan Kim
2010-11-23 14:57 ` Ben Gamari
2010-11-24 0:13 ` KOSAKI Motohiro
2010-11-23 9:28 ` Mel Gorman
2010-11-23 23:24 ` Minchan Kim
2010-11-24 10:02 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101122210132.be9962c7.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=npiggin@kernel.dk \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).